전남대_FE_이은진 2주차 과제 step1 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 3, 2024 23:13
tlsehdfl
reviewed
Jul 5, 2024
| import Header from '@/Layout/Header'; | ||
|
|
||
| interface LayoutProps { | ||
| isLoggedIn: boolean; |
There was a problem hiding this comment.
Layout 에서 props 로 전달받는 것 보다는 사용처에서 context 에 접근하여 로그인 상태를 가져오게끔 할 수 있을거 같습니다.
ref. https://react.dev/learn/passing-data-deeply-with-context
| import PersonButton from '@/components/common/HomeComponents/Ranking/PersonButton'; | ||
| import RankTypeButton from '@/components/common/HomeComponents/Ranking/RankButton'; | ||
|
|
||
| const initialFilterOption = { |
There was a problem hiding this comment.
targetType 과 rankType 이 별개의 타입 같은데 하나의 state 로 관리하는 이유가 있을까요 ?
분리하고 타입 지정하는게 더 나을거 같아요.
// e.g.
const [targetType, setTargetType] = useState<TargetType>('ALL');
const [rankType, setRankType] = useState<RankType>('MANY_WISH');
|
|
||
| export const ItemList = () =>{ | ||
|
|
||
| const [All, setAll] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [All, setAll] = useState(false); | |
| const [all, setAll] = useState(false); |
|
lint 설정 제대로 되어 있는지 전반적으로 확인 부탁드려요 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님 !
2주차 과제 step1까지 제출입니다. 고쳐야 할 사항이나 불필요한 부분이 있다면 말씀 부탁드립니다.