-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경북대 FE_김민주 5주차 과제 Step 3 #99
Open
joojjang
wants to merge
29
commits into
kakao-tech-campus-2nd-step2:joojjang
Choose a base branch
from
joojjang:feat-KimMinjoo
base: joojjang
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
경북대 FE_김민주 5주차 과제 Step 3 #99
joojjang
wants to merge
29
commits into
kakao-tech-campus-2nd-step2:joojjang
from
joojjang:feat-KimMinjoo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- useGetProductDetail 훅에서 쓰이는 axios를 Jest에서 처리하지 못하는 문제 - Jest 설정을 수정하고 Babel로 ES -> CommonJS로 변환하도록 했으나 해결 안 됨
- 현금 영수증 true/false일 때 각각 폼이 활성화/비활성화되는지 - 현금 영수증 true일 때 값이 입력되었는지 - 세 가지 테스트 모두 통과
- ESM - CommonJS 문제 때문에 실행 안 됨
danmin20
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨플릭트 해결 후 머지하시면 되겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 3 질답 추가하였습니다.