fix(FEC-14248): shouldAddKs to be based on if the session contains ks #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
Closed
SivanA-Kaltura
approved these changes
Feb 10, 2025
roeedean
added a commit
to kaltura/playkit-js-providers
that referenced
this pull request
Feb 10, 2025
### Description of the Changes - Added a new service for Kaltura User Get using it inside the OVPProvider - Concentrated the dealing with the flag config.session._isAnonymous in a single place in the file, instead of several places. - Fixed the flag config.session._isAnonymous logic: until now, config.session._isAnonymous was set to 'false' for every session that has ks (even if it's anonymous ks). The fix insure that the flag config.session._isAnonymous will be set to 'false' only for sessions that have ks containing a valid user inside, otherwise the flag will be set to 'true'. Related PR: kaltura/kaltura-player-js#916 [FEC-14248](https://kaltura.atlassian.net/browse/FEC-14248) [FEC-14248]: https://kaltura.atlassian.net/browse/FEC-14248?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Roee Dean <[email protected]>
roeedean
added a commit
to kaltura/playkit-js-providers
that referenced
this pull request
Feb 11, 2025
…261) ### Description of the Changes - Fix for always adding ks as a parameter for 'OVPProviderParser.getMediaEntry' and 'OVPProviderParser.getBumper'. Related PR: [259](#259) [916](kaltura/kaltura-player-js#916) [FEC-14248](https://kaltura.atlassian.net/browse/FEC-14248) [FEC-14248]: https://kaltura.atlassian.net/browse/FEC-14248?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Roee Dean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
shouldAddKs to be based on if the session contains ks instead of session.isAnonymous === false
Related PR: kaltura/playkit-js-providers#259
FEC-14248