fix(FEC-14262): Player v7 | Quiz | Wrong first element focus on quiz questions overlay. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semarche-kaltura
requested changes
Dec 16, 2024
src/components/quiz-question/reflection-point/reflection-point.tsx
Outdated
Show resolved
Hide resolved
…e quiz-question-wrapper
semarche-kaltura
requested changes
Dec 16, 2024
| @@ -72,8 +72,12 @@ export const QuizQuestionWrapper = withText(translates)((props: QuizQuestionWrap | |||
| useEffect(() => { | |||
| setSelected(getSelected(qui)); | |||
| setIsLoading(false); | |||
| if(qui.q.questionType === KalturaQuizQuestionTypes.Reflection){ | |||
There was a problem hiding this comment.
can we use condition:
if (qui.a || qui.q.questionType === KalturaQuizQuestionTypes.Reflection) {
continueButtonRef.current?.focus();
}
to avoid duplication of continueButtonRef.current?.focus();
semarche-kaltura
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When question overlay is opened, focus is not moved to first element in the overlay.
Root cause:
tabindex=0 was removed from legend element since it's not an interactive element.
Fix:
Move the focus to first interactive element in the overlay instead of to legend element.
Solves FEC-14262