Skip to content

Commit

Permalink
fix(SUP-46065): Player shows VR button based on "360" (or variations)…
Browse files Browse the repository at this point in the history
… tag
  • Loading branch information
yambenari24 committed Feb 2, 2025
1 parent 8a264f6 commit 87868c7
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
4 changes: 1 addition & 3 deletions src/k-provider/common/base-provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default class BaseProvider<MI> {
public _logger: any;
public _referrer?: string;
protected _isAnonymous: boolean;
public vrTag?: string;

public _networkRetryConfig: ProviderNetworkRetryParameters = {
async: true,
Expand Down Expand Up @@ -61,7 +60,7 @@ export default class BaseProvider<MI> {
return this._isAnonymous;
}

constructor(options: ProviderOptionsObject, playerVersion: string, vrTag?: string) {
constructor(options: ProviderOptionsObject, playerVersion: string) {
setLogger(options.logger);
this._partnerId = options.partnerId;
this._widgetId = options.widgetId;
Expand All @@ -70,7 +69,6 @@ export default class BaseProvider<MI> {
this._ks = options.ks || '';
this._playerVersion = playerVersion;
this._referrer = options.referrer;
this.vrTag = vrTag;
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
Expand Down
20 changes: 14 additions & 6 deletions src/k-provider/ovp/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,15 @@ import {

export default class OVPProvider extends BaseProvider<OVPProviderMediaInfoObject> {
private _filterOptionsConfig: ProviderFilterOptionsObject = {redirectFromEntryId: true};
private _vrPluginIsOn = false
private _vrTag: string | null = null;
/**
* @constructor
* @param {ProviderOptionsObject} options - provider options
* @param {string} playerVersion - player version
* @param {vrTag} - vr tag if exist
*/
constructor(options: ProviderOptionsObject, playerVersion: string, vrTag?: string) {
super(options, playerVersion, vrTag);
constructor(options: ProviderOptionsObject, playerVersion: string) {
super(options, playerVersion);
this._logger = getLogger('OVPProvider');
OVPConfiguration.set(options.env);
this._setFilterOptionsConfig(options.filterOptions);
Expand Down Expand Up @@ -362,10 +363,17 @@ export default class OVPProvider extends BaseProvider<OVPProviderMediaInfoObject
sourcesObject.captions = mediaEntry.sources.captions;
}

if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(', ').includes(this.vrTag)) {
sourcesObject.vr = {};
}
if(this._vrPluginIsOn && this._vrTag)
if (mediaEntry.metadata && typeof mediaEntry.metadata.tags === 'string' && mediaEntry.metadata.tags.split(', ').includes(this._vrTag)) {
sourcesObject.vr = {};
}
Object.assign(sourcesObject.metadata, mediaEntry.metadata);
return sourcesObject;
}

// eslint-disable-next-line @typescript-eslint/explicit-function-return-type
public _updatePlayerVrPluginIsOn(vrTag: string) {
this._vrTag = vrTag
this._vrPluginIsOn = true
}
}

0 comments on commit 87868c7

Please sign in to comment.