Setup e2e tests #185
Setup e2e tests #185
Conversation
rmn-boiko
force-pushed
the
feat/add-e2e-tests
branch
4 times, most recently
from
168e611 to
f12ee5a
Compare
rmn-boiko
force-pushed
the
feat/add-e2e-tests
branch
2 times, most recently
from
f2e3c6e to
e8e0fb8
Compare
rmn-boiko
force-pushed
the
feat/add-e2e-tests
branch
from
e8e0fb8 to
4f52d8b
Compare
.github/workflows/build.yaml
Outdated
| env: | ||
| SQLX_OFFLINE: false | ||
| DATABASE_URL: sqlite://kamu.sqlite.db | ||
| # platform(target) is a workaround for Windows only issue in cargo-nextest upon proc macro crates |
There was a problem hiding this comment.
We don't have Windows agents for kamu-node CI
Makefile
Outdated
| $(KAMU_CONTAINER_RUNTIME_TYPE) stop kamu-postgres || true && $(KAMU_CONTAINER_RUNTIME_TYPE) rm kamu-postgres || true | ||
| $(foreach crate,$(POSTGRES_CRATES),rm $(crate)/.env -f ;) |
There was a problem hiding this comment.
Q: what if I work with two repos (kamu-cli & kamu-node), will they use the same DB (container)?
There was a problem hiding this comment.
Yeah, changed to unique one
resources/openapi-mt.json
Outdated
| @@ -942,20 +942,9 @@ | |||
| ] | |||
| } | |||
| }, | |||
| "/odata/{account_name}": { | |||
There was a problem hiding this comment.
Looks like a mistake, because we need an account
GET https://api.europort.kamu.dev/odata/acme.fishing.co
<?xml version="1.0" encoding="utf-8"?>
<service xml:base="https://api.europort.kamu.dev/odata"
xmlns="http://www.w3.org/2007/app"
xmlns:atom="http://www.w3.org/2005/Atom">
<workspace>
<atom:title>default</atom:title>
<collection href="vessels.location-annotated">
<atom:title>vessels.location-annotated</atom:title>
</collection>
<collection href="vessels.location-trawl">
<atom:title>vessels.location-trawl</atom:title>
</collection>
<collection href="vessels.gps">
<atom:title>vessels.gps</atom:title>
</collection>
<collection href="vessels.trawl">
<atom:title>vessels.trawl</atom:title>
</collection>
<collection href="vessels.fuel">
<atom:title>vessels.fuel</atom:title>
</collection>
</workspace>
</service>There was a problem hiding this comment.
YEah, for some reason, it generetage wrong spec
| pub fn with_multi_tenant(mut self) -> Self { | ||
| self.is_multi_tenant = true; | ||
|
|
||
| self | ||
| } |
There was a problem hiding this comment.
in my opinion, we want to test kamu-node always in mt mode.
Q: in what case, do we benefit from st?
There was a problem hiding this comment.
agree, I actually did like this in the first time, but after I saw that there are chance to start it in st mode, but it will be much easier to keep it always mt
| Self::new(options, Some(kamu_config)) | ||
| } | ||
|
|
||
| pub fn mysql(mysql_pool: &MySqlPool, options: KamuNodeApiServerHarnessOptions) -> Self { |
| token: Option<AccessToken>, | ||
| } | ||
|
|
||
| impl KamuApiServerClient { |
There was a problem hiding this comment.
General question: can we generalize (in trait) the methods of both clients? And in case of difference, have kamu-cli and kamu-node specific implementations?
There was a problem hiding this comment.
good suggestion, will add a follow up improvements to move this to separate crate in kamu-cli and reuse it here
| S: AsRef<std::ffi::OsStr>, | ||
| T: Into<Vec<u8>> + Send; | ||
|
|
||
| async fn complete<T>(&self, input: T, current: usize) -> Vec<String> |
There was a problem hiding this comment.
I think some of the methods of this trait can be removed -- like this one, we don't plan to use autocomplete for kamu-node :)
There was a problem hiding this comment.
yeah, doublechecked, and cleanedup some methods
There was a problem hiding this comment.
those are definitely unneeded files (all *.sqlite)
rmn-boiko
force-pushed
the
feat/add-e2e-tests
branch
2 times, most recently
from
8ecc739 to
8dc0cba
Compare
rmn-boiko
force-pushed
the
feat/add-e2e-tests
branch
from
8dc0cba to
39b5bde
Compare
No description provided.