Add Characters to LibreLingo python scripts#3405
Open
Skivling wants to merge 5 commits into
Open
Conversation
Author
|
I have made the IPA field a list because it's quite common for a character to represent a few distinct but similar sounds. Same as the transliteration field. Should the transliteration field be renamed as Transliterations (plural) to indicate this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the preliminary work for #1143, implementing them in Python. Later, once @kantord is up to it in the web app rewrite they can be implemented there.
I have made some assumptions for what best to name the titles in Yaml and functions, which I am fine changing if there is a better option.
I have also added a property in Characters for their International Phonetic Alphabet (IPA) pronounciations, as I believe this would be useful to have below or above the characters for some learners, especially those who are very into linguistics and/or learning a conlang in a LibreLingo course.
The IPA value is not required in the schema so not including it won't cause any errors.
I hope unicode and such doesn't cause any bugs or errors such as a new character not displaying properly. 🤞
Currently Character()s in a skill look like this:
And here they are in Python:
I have yet to finish the in-code documentation of the functions, then adding all this to the proper docs, hence this PR is a draft. I also haven't tested anything yet.