Skip to content

Bug in n_joints #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 277 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
277 commits
Select commit Hold shift + click to select a range
1c36d06
Updated to fix bug as per original repo
Samleo8 Apr 13, 2020
e5468cb
Update data processing
Samleo8 Apr 20, 2020
b8beebb
Working on data organsiation
Samleo8 Apr 21, 2020
8aa2fb9
Label generation update
Samleo8 Apr 22, 2020
27d2571
Updated cmu config files according to #24
Samleo8 Apr 22, 2020
0ee2030
Added cmu frames from #19
Samleo8 Apr 22, 2020
11d0e23
Update label generation
Samleo8 Apr 24, 2020
4cd6e3c
Update camera label gen
Samleo8 Apr 24, 2020
288f57b
Fixed issues with strings
Samleo8 Apr 24, 2020
a150b84
Fixed issues with strings
Samleo8 Apr 24, 2020
789eab0
Succesfully produced labels file
Samleo8 Apr 24, 2020
dd872de
Obtaining BBOX Data labels
Samleo8 Apr 24, 2020
9555c6b
Updated README for cmu panoptic instructions
Samleo8 Apr 25, 2020
e8bb878
Moved bbox generation to single script as generation is slow
Samleo8 Apr 25, 2020
eafb073
Updated usage and bbox collection file
Samleo8 Apr 25, 2020
bbfa7db
Working bbox collection, with npy file
Samleo8 Apr 25, 2020
793a875
Issues with bbox npy file
Samleo8 Apr 25, 2020
7a96a27
Updatd bbox script
Samleo8 Apr 25, 2020
f15e049
Updated gitignore to exclude npy files
Samleo8 Apr 25, 2020
b87451e
Updated bbox script with readme
Samleo8 Apr 28, 2020
1b17fc5
Updated gitignore to ignore all npy files
Samleo8 Apr 28, 2020
c56e84c
Updated gitignore..
Samleo8 Apr 28, 2020
ee29a68
Updated readme
Samleo8 Apr 28, 2020
03b8042
Updated readme for cmu preprocessing
Samleo8 Apr 28, 2020
3eeb17d
Updated readme again
Samleo8 Apr 28, 2020
483fa25
Update debug statements
Samleo8 Apr 28, 2020
fff214c
yaml config updates
Samleo8 Apr 28, 2020
57230e7
Updated yaml save directories
Samleo8 Apr 28, 2020
5842976
Updated directory paths
Samleo8 Apr 28, 2020
e6369c4
Updated directory paths (cmu)
Samleo8 Apr 28, 2020
dd44338
Fixed comments
Samleo8 Apr 28, 2020
192199f
Updated CMU panoptic handler
Samleo8 Apr 28, 2020
af10652
Label generation py updated to prevent crashing when dir not found
Samleo8 Apr 28, 2020
0a0d26f
Updated labels and bbox file with debugging flag
Samleo8 Apr 28, 2020
4e4ce1d
Trying to gitignore cmu bboxes.npy
Samleo8 Apr 28, 2020
a75795a
Refuses to gitignore?
Samleo8 Apr 28, 2020
d91992a
Fixed issue with label generation
Samleo8 Apr 28, 2020
d5441c4
Fixed untracked files
Samleo8 Apr 28, 2020
ebb50d6
I thought this was previously fixed
Samleo8 Apr 28, 2020
9cebcff
Removed possibly unnecessary comment
Samleo8 Apr 29, 2020
44ca3f9
Try to make sure that file does not save incorrectly
Samleo8 Apr 29, 2020
cdf497a
Minor updates to readmes
Samleo8 Apr 29, 2020
a7f7f32
Attempt with multiprocessing/
Samleo8 Apr 29, 2020
95139a4
Moved bbox squaring over to cmu panoptic for transportability
Samleo8 Apr 29, 2020
3d1dc33
Moved bbox squaring over to cmu panoptic for transportability
Samleo8 Apr 29, 2020
e168c92
Moved bbox squaring over to cmu panoptic for transportability
Samleo8 Apr 29, 2020
da00737
Fixed readme minor issues
Samleo8 Apr 29, 2020
2394755
Added multiprocessing capabilities
Samleo8 Apr 29, 2020
58fe967
Error with array loading
Samleo8 Apr 29, 2020
c2c533a
Fixed issue with extra array loading
Samleo8 Apr 29, 2020
c1e75e5
Attempt to add multiprocessing capabilities
Samleo8 Apr 29, 2020
a2b19f8
Fixed issue with over-making bboxes... Removed multiprocessing for fi…
Samleo8 Apr 29, 2020
f33cfc6
Removed unnecessary code
Samleo8 Apr 29, 2020
b91dc18
Updated to do so focus on remapping keypoints
Samleo8 Apr 29, 2020
01abed7
Remove unnecessary .png replace
Samleo8 Apr 29, 2020
d9979e2
Remove misleading debugging statements
Samleo8 Apr 29, 2020
a8f0de1
Remove misleading debugging statements
Samleo8 Apr 29, 2020
2463905
Debug test
Samleo8 Apr 29, 2020
861a24a
Debug test
Samleo8 Apr 29, 2020
34c9c74
Debug test
Samleo8 Apr 29, 2020
6715e17
Debug test
Samleo8 Apr 29, 2020
183d591
Debug test
Samleo8 Apr 29, 2020
0975ccb
Issues with missing views hmm
Samleo8 Apr 29, 2020
02eeb6a
Removed unneeded todo statements
Samleo8 Apr 29, 2020
13e9633
Fixed exceptions thrown on missing views
Samleo8 Apr 29, 2020
51b5e68
Added debug mode for list of missing data
Samleo8 May 1, 2020
1697ea6
Added cmu mapping to vis.py
Samleo8 May 10, 2020
e5cb6c4
Added mpii joint positions
Samleo8 May 10, 2020
77c1744
Updated train
Samleo8 May 10, 2020
0f82f5c
Modifying dataset viewer
Samleo8 May 10, 2020
cb904db
Minor update
Samleo8 May 10, 2020
86cd7e0
Update to reflect retval dict
Samleo8 May 10, 2020
c90eb9b
Minor update to cmu view dataset
Samleo8 May 10, 2020
2c1a3e1
Updated file dir in README
Samleo8 May 11, 2020
b9daa29
Resolved error in dataset viewer
Samleo8 May 11, 2020
c4cb784
updated readme
Samleo8 May 11, 2020
83a7a58
Added shebang
Samleo8 May 11, 2020
51c94bf
More eror fix
Samleo8 May 11, 2020
b9f913a
Ignore bbox confidences
Samleo8 May 11, 2020
8785e0e
Mislabelling
Samleo8 May 11, 2020
230b188
Added function to save images instead
Samleo8 May 11, 2020
5291feb
Updated printing statement
Samleo8 May 11, 2020
033a3d9
Fixed minor bugs
Samleo8 May 11, 2020
62dc643
path update
Samleo8 May 11, 2020
e1a9b2f
Update view dataset
Samleo8 May 11, 2020
28ecfd5
Update view dataset
Samleo8 May 11, 2020
c5fff3b
Update view dataset
Samleo8 May 11, 2020
50c3633
Update view dataset
Samleo8 May 11, 2020
6b46c82
Update view dataset
Samleo8 May 11, 2020
1296afe
Update view dataset
Samleo8 May 11, 2020
91f0b3b
Update view dataset
Samleo8 May 11, 2020
4fdd9a8
Updated readme
Samleo8 May 11, 2020
0f8fb0c
Update view dataset
Samleo8 May 11, 2020
3f5069d
Update view dataset
Samleo8 May 11, 2020
8284c6b
Removed readme trailing spaces
Samleo8 May 11, 2020
ce012f5
Updated gitignore
Samleo8 May 11, 2020
c33aa38
Update view dataset
Samleo8 May 11, 2020
380c9b0
Update view dataset
Samleo8 May 11, 2020
75f9ffd
Updated gitignore
Samleo8 May 11, 2020
8521efc
Removed unnecessary images
Samleo8 May 11, 2020
7bea3fe
Moved retrieve from server script
Samleo8 May 11, 2020
97c2c61
Update viewdataset
Samleo8 May 11, 2020
b676d32
Moved retrieve from server
Samleo8 May 11, 2020
3f46762
Update viewd ataset
Samleo8 May 11, 2020
43ed4c5
Remapping seems unnecessary
Samleo8 May 11, 2020
805c036
See if bbox squaring algo makes a diff
Samleo8 May 11, 2020
6412631
Issue with cuboid side?
Samleo8 May 11, 2020
a16f729
Issue with cuboid side?
Samleo8 May 11, 2020
e3436fc
Updated image shape and removed bbox squareing
Samleo8 May 11, 2020
1c5100d
Issue with squaring?
Samleo8 May 11, 2020
f11b000
Unsure what's the issue
Samleo8 May 11, 2020
89b21c5
Added view dataset script
Samleo8 May 11, 2020
8a61512
Added view dataset script
Samleo8 May 11, 2020
e3cf9fc
Updated debug statement
Samleo8 May 11, 2020
db25b12
Removing todo statements
Samleo8 May 11, 2020
3a886a8
Updating debug statements
Samleo8 May 11, 2020
aeaa914
Updatd view script
Samleo8 May 11, 2020
db1fc1b
Updated view script
Samleo8 May 11, 2020
0606187
Updated view dataset
Samleo8 May 11, 2020
a81328d
Updated gitignore
Samleo8 May 11, 2020
7fa6927
Removed unnecessary files
Samleo8 May 11, 2020
7fa649e
Adding timestamp to dataset viewing to improve porting
Samleo8 May 11, 2020
a3fcc24
Adding timestamp to dataset viewing to improve porting
Samleo8 May 11, 2020
fd7ae56
Merge branch 'master' of github.com:Samleo8/learnable-triangulation-p…
Samleo8 May 11, 2020
6d1da60
Update
Samleo8 May 11, 2020
490f8c6
Merge branch 'master' of github.com:Samleo8/learnable-triangulation-p…
Samleo8 May 11, 2020
7fabb52
Fixed timestamp issues
Samleo8 May 11, 2020
0036017
Update view script with timestamp
Samleo8 May 11, 2020
72ad131
Try with different camera
Samleo8 May 11, 2020
dac0f63
Merge branch 'master' of github.com:Samleo8/learnable-triangulation-p…
Samleo8 May 11, 2020
e11f259
Update retrieve from server script to remove old files by default
Samleo8 May 11, 2020
ed5abce
Try without cropping
Samleo8 May 11, 2020
09bd960
Try different camera 2
Samleo8 May 11, 2020
8e4a1e8
Changing colours
Samleo8 May 11, 2020
333face
Change colours and try again
Samleo8 May 11, 2020
e1e390f
Display number as well
Samleo8 May 11, 2020
bf4fff6
Added bbox rectangle drawing function
Samleo8 May 11, 2020
74cc9bd
Fixed minor error
Samleo8 May 11, 2020
a15ac4b
Updated bbox
Samleo8 May 11, 2020
46d93db
Updated bbox viewing
Samleo8 May 11, 2020
6e9cfaf
Message ot say when no bbox available
Samleo8 May 12, 2020
1e504c1
Standardised from tuple to array
Samleo8 May 12, 2020
f82125b
Indexing problem?
Samleo8 May 12, 2020
e99cb79
Updated label generation for bboxes
Samleo8 May 12, 2020
4997a88
indexing was never wrong
Samleo8 May 12, 2020
3d52ddd
Now showing correct bbox
Samleo8 May 12, 2020
eb9da7f
Debugging statement
Samleo8 May 12, 2020
785269a
Fixed minor error
Samleo8 May 12, 2020
1d43795
Stupid error
Samleo8 May 12, 2020
294dedf
Added more debugging statemnts
Samleo8 May 12, 2020
c943afe
Updated debug messages
Samleo8 May 12, 2020
d2d2a4a
Remove unnecessary comments
Samleo8 May 12, 2020
6654bc7
More debugging messages
Samleo8 May 12, 2020
c69ce3e
Problem seems to lie with image resizing
Samleo8 May 12, 2020
3dc3224
Possibly erroneously changing from TLBR to LTRB
Samleo8 May 12, 2020
600e113
Fixed bbox coords issue
Samleo8 May 12, 2020
048305e
Fixed issue with bbox; now have to fix scaling
Samleo8 May 12, 2020
b2ec676
Fixed debugging statements
Samleo8 May 12, 2020
f6b397d
BBox resizing
Samleo8 May 12, 2020
8451b65
try with image_shape
Samleo8 May 12, 2020
952d959
rectangle changed
Samleo8 May 12, 2020
71c66fe
Remove try except
Samleo8 May 12, 2020
873dccb
Resolved issue with int
Samleo8 May 12, 2020
4436d0a
Fixed issue with ratio
Samleo8 May 12, 2020
676d97d
Ratio 2
Samleo8 May 12, 2020
b4aa66a
Check for bbox squaring
Samleo8 May 12, 2020
48821f1
Detections after resize
Samleo8 May 12, 2020
b052dc5
Square bbox after resize
Samleo8 May 12, 2020
791948d
Testing different settings
Samleo8 May 12, 2020
254cd53
Prevent key error
Samleo8 May 12, 2020
e48e6cd
Settings 2
Samleo8 May 12, 2020
97019fd
Update settings to match training
Samleo8 May 12, 2020
57745c6
Updated settings again
Samleo8 May 12, 2020
e3d53fc
Per pose error?
Samleo8 May 12, 2020
9b3546d
Create eval cmu script
Samleo8 May 12, 2020
81ca098
Minor changes
Samleo8 May 12, 2020
4ec877a
Made eval_cmu script
Samleo8 May 12, 2020
32aedc6
Try tracing
Samleo8 May 12, 2020
2172d35
Merge branch 'master' of github.com:Samleo8/learnable-triangulation-p…
Samleo8 May 12, 2020
89defa2
Update trace
Samleo8 May 12, 2020
17b5fa0
debug
Samleo8 May 12, 2020
d69e4ec
More trace
Samleo8 May 12, 2020
880bce4
More trace
Samleo8 May 12, 2020
3331381
More trace
Samleo8 May 12, 2020
0112c0d
More trace
Samleo8 May 12, 2020
74bcb6c
More trace
Samleo8 May 12, 2020
2949c00
More trace
Samleo8 May 12, 2020
bd9c264
Update comments
Samleo8 May 13, 2020
ad5ee41
Restyle
Samleo8 May 13, 2020
068e106
Testing problem with data size
Samleo8 May 13, 2020
3cf83b7
Moved bbox resizing code to dataset viewer to save data space
Samleo8 May 13, 2020
8d953e9
Bug in viewdataset
Samleo8 May 13, 2020
3942c19
Debugging 2
Samleo8 May 13, 2020
983eefe
Fixed bugs with view data
Samleo8 May 13, 2020
df64dfd
Fixed bugs with view data
Samleo8 May 13, 2020
d2077bf
Force pickle protocol to 4
Samleo8 May 13, 2020
79a9426
Debugging 2
Samleo8 May 13, 2020
4256305
Attempt to solve pickle problem with custom reducer
Samleo8 May 13, 2020
3ba3fa8
Removing unnecessary data in sample
Samleo8 May 13, 2020
cb621a6
Fixed typo
Samleo8 May 13, 2020
c52685d
Update data breakdown info
Samleo8 May 13, 2020
4a31cb7
Remove keypoint printing.
Samleo8 May 13, 2020
01776d2
Removed debugging 2
Samleo8 May 13, 2020
fd4dcba
Added small tester
Samleo8 May 13, 2020
74f201f
Update eval script
Samleo8 May 13, 2020
57e2d3d
Update eval script
Samleo8 May 13, 2020
affe00f
Eval cmu
Samleo8 May 13, 2020
bdbb02a
What'st wrong
Samleo8 May 13, 2020
5f5333d
Update eval script
Samleo8 May 13, 2020
5238a39
Update panoptic
Samleo8 May 13, 2020
fb19703
Problem with missing poses
Samleo8 May 13, 2020
7a43f0f
Testing
Samleo8 May 13, 2020
a3a821a
smaller dataset test
Samleo8 May 13, 2020
2890e18
TRy to reduce batch size
Samleo8 May 13, 2020
088fea8
Debugging issue with projection matrices
Samleo8 May 13, 2020
cbb9cb4
Why no print
Samleo8 May 13, 2020
43524dd
debug attempt 2
Samleo8 May 13, 2020
fda7f54
debug 2
Samleo8 May 13, 2020
8e06bd1
what
Samleo8 May 13, 2020
3a7fc9a
what 2
Samleo8 May 13, 2020
e23cdc2
Try with sth that makes more sense
Samleo8 May 13, 2020
e1181d8
whoops
Samleo8 May 13, 2020
4fdc0dd
Force coco vis
Samleo8 May 13, 2020
ef8b98c
Try again
Samleo8 May 13, 2020
2b8a67e
Updated comments
Samleo8 May 13, 2020
85be388
Comments for config file: See if need change batch size
Samleo8 May 13, 2020
9dc4e05
Updated comments; fixed issue with array splice
Samleo8 May 13, 2020
98a09fb
Revert to old
Samleo8 May 13, 2020
7526b7a
Removed debugging
Samleo8 May 13, 2020
c3efabc
Various comments and debugging
Samleo8 May 13, 2020
580be4a
Updated readme
Samleo8 May 13, 2020
fbb1468
Added ignore cameras for CMU
Samleo8 May 13, 2020
f9e7434
More debug statements
Samleo8 May 14, 2020
cb266ea
error with yaml
Samleo8 May 14, 2020
277b6dc
error with yaml 2
Samleo8 May 14, 2020
0264a57
Debugging
Samleo8 May 14, 2020
a6e800a
Remove unnecessary assert statement for ignore cameras
Samleo8 May 14, 2020
a2705e6
debugging 2
Samleo8 May 14, 2020
fd6865c
updated ignore cameras
Samleo8 May 14, 2020
30e5db9
Ignore cameras bug fixed
Samleo8 May 14, 2020
5cc92b1
Ignore camera fix 2
Samleo8 May 14, 2020
42d29fc
Starting documentation on genericdataset
Samleo8 May 14, 2020
d689af2
Problems with base joint
Samleo8 May 14, 2020
795a349
Debug attempt 2
Samleo8 May 14, 2020
306d945
Added eval h36m script'
Samleo8 May 14, 2020
6cd39ff
try to transpose keypoiints
Samleo8 May 14, 2020
b450b61
Debug more
Samleo8 May 14, 2020
1b76439
Cloning straight from parent repo
Samleo8 May 14, 2020
d0f2439
Fixed issue with n_joints
Samleo8 May 14, 2020
48c47f1
Revert gitignore
Samleo8 May 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mvn/utils/multiview.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def update_after_crop(self, bbox):

def update_after_resize(self, image_shape, new_image_shape):
height, width = image_shape
new_width, new_height = new_image_shape
new_height, new_width = new_image_shape

fx, fy, cx, cy = self.K[0, 0], self.K[1, 1], self.K[0, 2], self.K[1, 2]

Expand Down
2 changes: 1 addition & 1 deletion train.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def one_epoch(model, criterion, opt, config, dataloader, device, epoch, n_iters_
keypoints_3d_pred, heatmaps_pred, volumes_pred, confidences_pred, cuboids_pred, coord_volumes_pred, base_points_pred = model(images_batch, proj_matricies_batch, batch)

batch_size, n_views, image_shape = images_batch.shape[0], images_batch.shape[1], tuple(images_batch.shape[3:])
n_joints = keypoints_3d_pred[0].shape[1]
n_joints = keypoints_3d_pred.shape[1]

keypoints_3d_binary_validity_gt = (keypoints_3d_validity_gt > 0.0).type(torch.float32)

Expand Down