-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cross-cluster unified query #4254
Conversation
bf8c75a
to
66c3087
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
I'll look at it ASAP. And really hope this feature can be included in v1.8.
Thank you @chaunceyjiang.
|
eb20e0a
to
cd2b284
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
- Coverage 52.80% 52.15% -0.65%
==========================================
Files 240 241 +1
Lines 23624 23915 +291
==========================================
Hits 12474 12474
- Misses 10471 10761 +290
- Partials 679 680 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/cc @RainbowMango @yizhang-zen @XiShanYongYe-Chang Ready for review. Please take a look. |
Thanks a lot |
Signed-off-by: chaunceyjiang <[email protected]> Co-authored-by: changzhen <[email protected]>
cd2b284
to
6ea7910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yizhang-zen I think we can tag a new release(v1.8.0-preview2), can you help to verify it on your environment? |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: