-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose assignReplicas and selectClusters function to external schedulers #4293
Conversation
7dbff59
to
4e6e1e2
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4293 +/- ##
==========================================
- Coverage 52.80% 52.78% -0.03%
==========================================
Files 240 241 +1
Lines 23624 23628 +4
==========================================
- Hits 12474 12471 -3
- Misses 10471 10477 +6
- Partials 679 680 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4e6e1e2
to
48016d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
48016d8
to
5030ec2
Compare
Is it sufficient to only export this method based on the description of the issue? |
f918b77
to
4b8e819
Compare
They just need |
89a4ed1
to
efc2757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if these two exposed functions meet your requirements. @wangyang0616
efc2757
to
bd46fcd
Compare
bd46fcd
to
4cfe13e
Compare
Please rebase this as we just introduced license check by #4204. A license header is required now for each Go file. |
Signed-off-by: chaosi-zju <[email protected]>
4cfe13e
to
a8629ac
Compare
The current pr can help us complete the reference of the scheduling policy. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Expose assignReplicas and selectClusters function to external schedulers
Which issue(s) this PR fixes:
Fixes #4279
Special notes for your reviewer:
@wangyang0616
Does this PR introduce a user-facing change?: