Added UTs for resourceregistry in pkg/generated

[yashpandey06]

/kind feature

Fixes part of #5236

Description

This PR introduces comprehensive unit tests for the ResourceRegistryLister implementation in the v1alpha1 package. The tests cover the following scenarios:

• List Method:

  • Verifies behavior with an empty indexer.
  • Confirms correct listing of ResourceRegistry objects when the indexer is populated.

• Get Method:

  • Tests retrieval of non-existent entries, ensuring a NotFound error is returned.
  • Validates successful retrieval of existing ResourceRegistry objects.
  • Simulates and tests error handling by using a mock indexer that returns an error.

These tests aim to ensure robustness and reliability of the ResourceRegistryLister functionality by covering both typical and edge cases.

Changes

• Added TestResourceRegistryLister_List to test the List method.
• Added TestResourceRegistryLister_Get to test the Get method, including error handling.
• Implemented a mockIndexer to simulate error scenarios.

Does this PR introduce a user-facing change?:
NONE

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.60%. Comparing base (bcf68fa) to head (d9ffb9a).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5417      +/-   ##
==========================================
+ Coverage   30.12%   30.60%   +0.48%     
==========================================
  Files         632      632              
  Lines       43936    43936              
==========================================
+ Hits        13236    13448     +212     
+ Misses      29742    29510     -232     
- Partials      958      978      +20     

Flag	Coverage Δ
unittests	30.60% <ø> (+0.48%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yashpandey06]

@XiShanYongYe-Chang Please help review this MR too .
Thanks !

[anujagrawal699]

Hey @yashpandey06 can you please update the file name from resourceregistry.go_test.go to resourceregistry_test.go.

[yashpandey06]

Hey @yashpandey06 can you please update the file name from resourceregistry.go_test.go to resourceregistry_test.go.

Apologies for that , fixed it

[yashpandey06]

Hey @yashpandey06 can you please update the file name from resourceregistry.go_test.go to resourceregistry_test.go.

Apologies for that , it has been fixed , we can move ahead with the review

[yashpandey06]

@XiShanYongYe-Chang Please help review this MR too . Thanks !

we can move ahead with the review part

[XiShanYongYe-Chang]

Hi @yashpandey06 Can you help complete the title, and help squash the commits into one?

[XiShanYongYe-Chang]

/assign

[yashpandey06]

@XiShanYongYe-Chang sure doing it

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yashpandey06]

@XiShanYongYe-Chang Apologies , would be squashing the commits into one in future.
Thanks !

[yashpandey06]

@XiShanYongYe-Chang , commits have been squashed , i think we can proceed 🙂

[XiShanYongYe-Chang]

Hi @yashpandey06 the pkg/generated is automatically generated by the code generation tool, so I'm not sure that adding tests for them is necessary. I looked at the kubernetes repository and they don't have test files either.

[yashpandey06]

Hi @yashpandey06 the pkg/generated is automatically generated by the code generation tool, so I'm not sure that adding tests for them is necessary. I looked at the kubernetes repository and they don't have test files either.

@XiShanYongYe-Chang so should i close this pr instead ?

[XiShanYongYe-Chang]

@XiShanYongYe-Chang so should i close this pr instead ?

Let's close it first.

[yashpandey06]

@XiShanYongYe-Chang so should i close this pr instead ?

Let's close it first.

Thanks for your feedback, closing it now .