-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for examples/customresourceinterpreter/webhook #5433
Added tests for examples/customresourceinterpreter/webhook #5433
Conversation
Signed-off-by: Anuj Agrawal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5433 +/- ##
==========================================
+ Coverage 30.94% 31.18% +0.23%
==========================================
Files 638 639 +1
Lines 44307 44313 +6
==========================================
+ Hits 13712 13818 +106
+ Misses 29604 29498 -106
- Partials 991 997 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@XiShanYongYe-Chang Please take a look. |
Thanks @anujagrawal699 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
"testing" | ||
) | ||
|
||
func TestNewWebhookCommand(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this test function may not actually be able to take care of the code quality.
To be honest, I don't know how to test the corresponding function. Let's accept it for now and replace it later if there is a better way to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, some functions are harder to test in this file. That's the reason i skipped some of them.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This pr introduces tests for karmada/examples/customresourceinterpreter/webhook/app/workloadwebhook.go and webhook.go.
Additions:
What type of PR is this?
/kind failing-test
/kind feature
What this PR does / why we need it:
This PR adds comprehensive tests for testing core functionality of customresourceinterpreter/webhook.
Which issue(s) this PR fixes:
Fixes a part of #5236
Does this PR introduce a user-facing change?: