Added tests for cmd/descheduler

[anujagrawal699]

Description:
This PR introduces tests for cmd/descheduler/app/descheduler.go .

What type of PR is this?
/kind failing-test
/kind feature

What this PR does / why we need it:
This PR adds comprehensive tests for testing core functionality of cmd/descheduler .

Which issue(s) this PR fixes:
Fixes a part of #5236

Does this PR introduce a user-facing change?:

NONE

[anujagrawal699]

Hey @XiShanYongYe-Chang is there a need to test cmd/descheduler/app/options/options.go?

[anujagrawal699]

I refactored the pr and tried to avoid tests that are likely to break with minor, inconsequential changes.

[anujagrawal699]

I FORGOT TO PULL THE LATEST COMMITS :) . @XiShanYongYe-Chang Please don't review i'll update the tests.

[XiShanYongYe-Chang]

Hi @anujagrawal699 the lint ci is failed.
/assign

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.27%. Comparing base (2efe03f) to head (9d5e86e).
Report is 110 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5445      +/-   ##
==========================================
+ Coverage   31.14%   31.27%   +0.13%     
==========================================
  Files         640      640              
  Lines       44417    44417              
==========================================
+ Hits        13832    13890      +58     
+ Misses      29583    29519      -64     
- Partials     1002     1008       +6     

Flag	Coverage Δ
unittests	31.27% <ø> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anujagrawal699]

@XiShanYongYe-Chang Please take a look.

[XiShanYongYe-Chang]

Thanks
/assign

[XiShanYongYe-Chang]

Too many arguments in call to 'serveHealthzAndMetrics'

[anujagrawal699]

@XiShanYongYe-Chang I made the same error. Few days a ago a commit changed the 'serveHealthzAndMetrics' and the new implementation is

func serveHealthzAndMetrics(healthProbeBindAddress, metricsBindAddress string) {
	if healthProbeBindAddress == metricsBindAddress {
		if healthProbeBindAddress != "0" {
			go serveCombined(healthProbeBindAddress)
		}
	} else {
		if healthProbeBindAddress != "0" {
			go serveHealthz(healthProbeBindAddress)
		}
		if metricsBindAddress != "0" {
			go serveMetrics(metricsBindAddress)
		}
	}
}

Your local might be behind by some commits.

[XiShanYongYe-Chang]

Can you rebase the latest master code and re-push it?

[anujagrawal699]

Okay

[XiShanYongYe-Chang]

Good job!
/lgtm
/approve

[XiShanYongYe-Chang]

This test case feels good 👍

[anujagrawal699]

I tried to keep it maintainable and not prone to break with minor changes.

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/descheduler/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anujagrawal699]

Hey @XiShanYongYe-Chang is there a need to test cmd/descheduler/app/options/options.go?

[XiShanYongYe-Chang]

Hey @XiShanYongYe-Chang is there a need to test cmd/descheduler/app/options/options.go?

Is it possible to make a valid test? If so, please add it.