Added tests for controllers/deploymentreplicassyncer #5493

anujagrawal699 · 2024-09-07T18:15:48Z

Description:
This PR introduces tests for deploymentreplicassyncer controller. The new addition tests significant logic of deploymentreplicassyncer controller.

Additions:

TestPredicateFunc:
- Added tests for various scenarios including label changes, replica changes, and different event types (Create, Update, Delete, Generic).
- Ensures the predicate function correctly filters relevant events.
TestSetupWithManager:
- Verifies that the controller can be properly set up with a manager.
TestReconcile:
- Added test cases for different reconciliation scenarios:
  - Successful replicas sync
  - Binding not found
  - Non-divided scheduling type
  - Replicas already synced
- Checks for correct result, error handling, and replica updates.
TestIsDeploymentStatusCollected:
- Covers various scenarios:
  - Fully collected status
  - Mismatched replicas
  - Generation mismatches
  - Incomplete aggregated status
  - Invalid JSON in status
  - Zero replicas in status
  - Mismatched status replicas

Test Coverage:
The test coverage of the deploymentreplicassyncer controller has been increased to 80.60% .

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

anujagrawal699 · 2024-09-08T05:54:09Z

The TestSetupWithManager is removed in the latest commit because it was causing CI failures and provided limited value in terms of testing the controller's core functionality.

codecov-commenter · 2024-09-08T06:03:48Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.00%. Comparing base (32c2ef7) to head (455cb39).
Report is 378 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5493       +/-   ##
===========================================
+ Coverage   31.70%   45.00%   +13.29%     
===========================================
  Files         643      658       +15     
  Lines       44445    53917     +9472     
===========================================
+ Hits        14090    24263    +10173     
+ Misses      29325    28080     -1245     
- Partials     1030     1574      +544

Flag	Coverage Δ
unittests	`45.00% <ø> (+13.29%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anujagrawal699 · 2024-09-13T07:18:57Z

@XiShanYongYe-Chang Please take a look.

zhzhuang-zju · 2024-11-11T03:34:28Z

/assign

pkg/controllers/deploymentreplicassyncer/deployment_replicas_syncer_controller_test.go

anujagrawal699 · 2024-11-14T08:55:29Z

@zhzhuang-zju PTAL

zhzhuang-zju · 2024-11-14T11:48:27Z

/lgtm
thanks cc @XiShanYongYe-Chang

XiShanYongYe-Chang · 2024-11-14T12:42:11Z

Thanks~
/assign

zhzhuang-zju · 2024-11-15T01:20:58Z

/lgtm

XiShanYongYe-Chang · 2024-11-15T01:28:11Z

pkg/controllers/deploymentreplicassyncer/deployment_replicas_syncer_controller_test.go

+			case tc.name == "create event":
+				result = predicateFunc.Create(event.CreateEvent{Object: tc.newObj})
+			case tc.name == "delete event":
+				result = predicateFunc.Delete(event.DeleteEvent{Object: tc.oldObj})
+			case tc.name == "generic event":


Generally, the name is read-only and may be changed frequently in the future. If the switch case statement is used, it is recommended that a type field be added to indicate the name.

I'll add an event type structure.

XiShanYongYe-Chang

Other parts lgtm, thanks~

Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]> Added tests for controllers/deploymentreplicassyncer Signed-off-by: Anuj Agrawal <[email protected]>

XiShanYongYe-Chang

/lgtm
/approve

karmada-bot · 2024-11-15T06:38:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controllers/OWNERS~~ [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 7, 2024

karmada-bot requested a review from mrlihanbo September 7, 2024 18:15

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 7, 2024

karmada-bot requested a review from Poor12 September 7, 2024 18:15

karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 7, 2024

anujagrawal699 mentioned this pull request Sep 7, 2024

Project Plan: Enhance Karmada controller-manager and schedule testing coverage (LFX 2024 TERM 3) #5470

Open

anujagrawal699 force-pushed the addedTests-pkg/controllers/deploymentreplicassyncer branch from 8c04229 to 1a16c6b Compare September 8, 2024 05:52

karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 8, 2024

anujagrawal699 force-pushed the addedTests-pkg/controllers/deploymentreplicassyncer branch from 1a16c6b to 9f02242 Compare September 9, 2024 10:44

karmada-bot assigned zhzhuang-zju Nov 11, 2024

zhzhuang-zju reviewed Nov 11, 2024

View reviewed changes

anujagrawal699 force-pushed the addedTests-pkg/controllers/deploymentreplicassyncer branch from 9f02242 to 54813b1 Compare November 12, 2024 12:17

karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024

karmada-bot assigned XiShanYongYe-Chang Nov 14, 2024

anujagrawal699 force-pushed the addedTests-pkg/controllers/deploymentreplicassyncer branch from 54813b1 to b765067 Compare November 14, 2024 15:10

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024

XiShanYongYe-Chang reviewed Nov 15, 2024

View reviewed changes

anujagrawal699 force-pushed the addedTests-pkg/controllers/deploymentreplicassyncer branch from b765067 to 455cb39 Compare November 15, 2024 05:35

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024

XiShanYongYe-Chang reviewed Nov 15, 2024

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024

karmada-bot merged commit e7fd4eb into karmada-io:master Nov 15, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added tests for controllers/deploymentreplicassyncer #5493

Added tests for controllers/deploymentreplicassyncer #5493

anujagrawal699 commented Sep 7, 2024 •

edited

Loading

anujagrawal699 commented Sep 8, 2024

codecov-commenter commented Sep 8, 2024 •

edited

Loading

anujagrawal699 commented Sep 13, 2024

zhzhuang-zju commented Nov 11, 2024

anujagrawal699 commented Nov 14, 2024

zhzhuang-zju commented Nov 14, 2024

XiShanYongYe-Chang commented Nov 14, 2024

zhzhuang-zju commented Nov 15, 2024

XiShanYongYe-Chang Nov 15, 2024

anujagrawal699 Nov 15, 2024

XiShanYongYe-Chang left a comment

XiShanYongYe-Chang left a comment

karmada-bot commented Nov 15, 2024

Added tests for controllers/deploymentreplicassyncer #5493

Added tests for controllers/deploymentreplicassyncer #5493

Conversation

anujagrawal699 commented Sep 7, 2024 • edited Loading

anujagrawal699 commented Sep 8, 2024

codecov-commenter commented Sep 8, 2024 • edited Loading

Codecov Report

anujagrawal699 commented Sep 13, 2024

zhzhuang-zju commented Nov 11, 2024

anujagrawal699 commented Nov 14, 2024

zhzhuang-zju commented Nov 14, 2024

XiShanYongYe-Chang commented Nov 14, 2024

zhzhuang-zju commented Nov 15, 2024

XiShanYongYe-Chang Nov 15, 2024

Choose a reason for hiding this comment

anujagrawal699 Nov 15, 2024

Choose a reason for hiding this comment

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

karmada-bot commented Nov 15, 2024

anujagrawal699 commented Sep 7, 2024 •

edited

Loading

codecov-commenter commented Sep 8, 2024 •

edited

Loading