-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/webhook: refactor Propagation Policy test #5537
pkg/webhook: refactor Propagation Policy test #5537
Conversation
In this commit, we refactor propagation policy names and check on number of patches the mutation happens. Signed-off-by: Mohamed Awnallah <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5537 +/- ##
==========================================
+ Coverage 33.71% 33.86% +0.15%
==========================================
Files 643 643
Lines 44500 44509 +9
==========================================
+ Hits 15001 15071 +70
+ Misses 28357 28289 -68
- Partials 1142 1149 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we refactor propagation policy names and check on number of patches after the mutation happens.
Motivation and Context
Motivated by @XiShanYongYe-Chang's comment #5494 (comment).
What type of PR is this?
/kind cleanup
Which issue(s) this PR fixes:
Follow-up on #5492.
Does this PR introduce a user-facing change?: