-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/webhook: unit test Interpreter #5542
pkg/webhook: unit test Interpreter #5542
Conversation
bbcf86e
to
f01637c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
==========================================
+ Coverage 34.14% 35.64% +1.50%
==========================================
Files 643 645 +2
Lines 44509 44994 +485
==========================================
+ Hits 15197 16038 +841
+ Misses 28156 27705 -451
- Partials 1156 1251 +95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/assign |
Hi @mohamedawnallah, can you help squash the commits into one? |
f01637c
to
1c5049f
Compare
Closing and reopening some flaky e2e test cases... |
Hi @XiShanYongYe-Chang, I've squashed the commits into single one and all tests passed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mohamedawnallah can you try to rewrite it as table drive?
1c5049f
to
1e73916
Compare
Thanks @XiShanYongYe-Chang for the feedback regards using the table driven method! It looks much cleaner now. I will ask for review when the GitHub CI tests finish :) |
In this commit, we introduce unit tests for the `Interpreter` webhook across `Decoder`, `HTTP`, `Injection`, `Response`, and `Webhook` components. Signed-off-by: Mohamed Awnallah <[email protected]>
1e73916
to
c571cfb
Compare
Thanks a lot~ Good job. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we introduce unit tests for the
Interpreter
webhook acrossDecoder
,HTTP
,Injection
,Response
, andWebhook
components.What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: