[Proposal] Support for resource scheduling suspend and resume capabilities #5690

Vacant2333 · 2024-10-13T20:41:03Z

What type of PR is this?

/kind design
/kind documentation

Which issue(s) this PR fixes:
Fixes #4937

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

codecov-commenter · 2024-10-13T20:53:35Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.40%. Comparing base (ba1e68d) to head (2fdd66a).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5690      +/-   ##
==========================================
+ Coverage   48.37%   48.40%   +0.03%     
==========================================
  Files         665      665              
  Lines       54795    54850      +55     
==========================================
+ Hits        26507    26552      +45     
- Misses      26569    26584      +15     
+ Partials     1719     1714       -5

Flag	Coverage Δ
unittests	`48.40% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/proposals/scheduling-suspension/README.md

Monokaix · 2024-11-28T01:58:57Z

Should also add rb status condition just like #5317.

docs/proposals/scheduling-suspension/README.md

Monokaix · 2024-12-09T07:06:43Z

/assign

RainbowMango

/assign

RainbowMango · 2024-12-28T07:03:56Z

docs/proposals/scheduling-suspension/README.md

+<!--
+Karmada 目前已经允许用户通过 Suspension 来暂停和恢复资源的 propagation 行为，这提高了 Karmada 的灵活性。
+
+但是目前 Suspension 支持的不够彻底，在 Karmada 中资源的分发可以简单理解为两个阶段，资源的调度和资源的传播。
+
+目前传播阶段可以较为灵活的由用户暂停和恢复，但是没有在调度阶段，没有提供暂停和恢复的能力。
+
+我们希望在 Karmada 的基础之上，通过暂停调度的方式，实现队列和配额管理等高阶能力，从而将集群有限的资源优先调度给高优先级的工作负载，增强 Karmada 在多集群调度的能力，从而满足用户在复杂场景下的需求。
+
+本文基于 [#5118](https://github.com/karmada-io/karmada/pull/5118) 在其中的 Suspension 基础之上，提供了暂停资源调度的能力。
+-->


Please remove all Chinese content from the proposal. We should only use English to describe and review the proposal to avoid issues like being out of sync.

RainbowMango · 2024-12-28T07:17:19Z

docs/proposals/scheduling-suspension/README.md

+-->
+Karmada scheduler listens the `ResourceBinding` resource , ignores the `ResourceBinding` resource when `ResourceBinding.Suspension.Scheduling`=true, pauses scheduling, and resumes scheduling when `ResourceBinding.Suspension.Scheduling`=false.
+
+And when the `ResourceBinding` has been successfully scheduled, it is no longer allowed to modify the `ResourceBinding` from non-suspended to suspended, and when `ResourceBinding.Suspension.Scheduling` is set to true or false, the corresponding condition is refreshed in the status of the `ResourceBinding`.


And when the ResourceBinding has been successfully scheduled, it is no longer allowed to modify the ResourceBinding from non-suspended to suspended,

It sounds like we need to introduce a validating webhook to force this, right? Can you explain why we need to do that?

Yeah I have considered that, becaue the scheduling suspension happened before scheduling success, and after rb is successfully scheduled it's no necessary to suspend rb again, which will also confuse users.

I think the work suspension has the same problem.

and after rb is successfully scheduled it's no necessary to suspend rb again, which will also confuse users.

Yeah, I agree, it brings ambiguousness if we don't force that.
I will track this on #5977.

RainbowMango

Generally looks good to me.
But, would you like to squash the commits?

Signed-off-by: Vacant2333 <[email protected]> Signed-off-by: Monokaix <[email protected]>

Monokaix · 2025-01-02T02:14:19Z

Generally looks good to me. But, would you like to squash the commits?

done

RainbowMango

/lgtm
/approve

karmada-bot · 2025-01-02T03:29:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Monokaix · 2025-01-02T06:09:25Z

/reopen

karmada-bot · 2025-01-02T06:09:29Z

@Monokaix: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RainbowMango · 2025-01-02T06:10:18Z

/reopen

karmada-bot · 2025-01-02T06:10:22Z

@RainbowMango: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

karmada-bot added kind/design Categorizes issue or PR as related to design. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 13, 2024

karmada-bot requested review from RainbowMango and Tingtal October 13, 2024 20:41

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2024

Vacant2333 marked this pull request as ready for review October 15, 2024 01:33

karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2024

karmada-bot requested a review from Poor12 October 15, 2024 01:33

KunWuLuan reviewed Oct 24, 2024

View reviewed changes

docs/proposals/scheduling-suspension/README.md Outdated Show resolved Hide resolved

Monokaix force-pushed the proposal-for-scheduling-suspension branch 5 times, most recently from 4e3260e to e0ca35f Compare December 3, 2024 01:53

kevin-wangzefeng reviewed Dec 3, 2024

View reviewed changes

docs/proposals/scheduling-suspension/README.md Outdated Show resolved Hide resolved

Monokaix force-pushed the proposal-for-scheduling-suspension branch from e0ca35f to ba71093 Compare December 9, 2024 03:12

karmada-bot assigned Monokaix Dec 9, 2024

Monokaix mentioned this pull request Dec 11, 2024

feat: cluster-level resource scheduling suspend and resume capabilities #5937

Merged

RainbowMango mentioned this pull request Dec 26, 2024

[Feature] [Alpha] Scheduling Suspend and Resume #5977

Open

8 tasks

RainbowMango reviewed Dec 28, 2024

View reviewed changes

karmada-bot assigned RainbowMango Dec 28, 2024

RainbowMango reviewed Dec 28, 2024

View reviewed changes

Monokaix force-pushed the proposal-for-scheduling-suspension branch from ba71093 to 971f7d1 Compare January 2, 2025 01:44

RainbowMango reviewed Jan 2, 2025

View reviewed changes

proposal-for-scheduling-suspension

2fdd66a

Signed-off-by: Vacant2333 <[email protected]> Signed-off-by: Monokaix <[email protected]>

Monokaix force-pushed the proposal-for-scheduling-suspension branch from 971f7d1 to 2fdd66a Compare January 2, 2025 02:13

RainbowMango approved these changes Jan 2, 2025

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025

karmada-bot closed this in #5937 Jan 2, 2025

karmada-bot reopened this Jan 2, 2025

karmada-bot merged commit b3b1aa6 into karmada-io:master Jan 2, 2025
35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

Vacant2333 commented Oct 13, 2024 •

edited by RainbowMango

Loading

codecov-commenter commented Oct 13, 2024 •

edited

Loading

Monokaix commented Nov 28, 2024

Monokaix commented Dec 9, 2024

RainbowMango left a comment

RainbowMango Dec 28, 2024

Monokaix Jan 2, 2025

RainbowMango Dec 28, 2024

Monokaix Dec 28, 2024

Monokaix Dec 28, 2024

RainbowMango Dec 28, 2024 •

edited

Loading

RainbowMango left a comment

Monokaix commented Jan 2, 2025

RainbowMango left a comment

karmada-bot commented Jan 2, 2025

Monokaix commented Jan 2, 2025

karmada-bot commented Jan 2, 2025

RainbowMango commented Jan 2, 2025

karmada-bot commented Jan 2, 2025

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

[Proposal] Support for resource scheduling suspend and resume capabilities #5690

Conversation

Vacant2333 commented Oct 13, 2024 • edited by RainbowMango Loading

codecov-commenter commented Oct 13, 2024 • edited Loading

Codecov Report

Monokaix commented Nov 28, 2024

Monokaix commented Dec 9, 2024

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Dec 28, 2024

Choose a reason for hiding this comment

Monokaix Jan 2, 2025

Choose a reason for hiding this comment

RainbowMango Dec 28, 2024

Choose a reason for hiding this comment

Monokaix Dec 28, 2024

Choose a reason for hiding this comment

Monokaix Dec 28, 2024

Choose a reason for hiding this comment

RainbowMango Dec 28, 2024 • edited Loading

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

Monokaix commented Jan 2, 2025

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Jan 2, 2025

Monokaix commented Jan 2, 2025

karmada-bot commented Jan 2, 2025

RainbowMango commented Jan 2, 2025

karmada-bot commented Jan 2, 2025

Vacant2333 commented Oct 13, 2024 •

edited by RainbowMango

Loading

codecov-commenter commented Oct 13, 2024 •

edited

Loading

RainbowMango Dec 28, 2024 •

edited

Loading