Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for pkg/util/helper/work.go #5742

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Added tests for pkg/util/helper/work.go #5742

merged 1 commit into from
Dec 31, 2024

Conversation

anujagrawal699
Copy link
Contributor

@anujagrawal699 anujagrawal699 commented Oct 24, 2024 •
edited
Loading

Description:
This PR adds comprehensive unit tests for untested functions of the module work from the helper utility package. It introduces new tests for previously uncovered functions and refactors existing tests to use the assert package from testify. These additions aim to increase code reliability, maintainability, and test coverage for the work helper.

Modifications:

  1. pkg/util/helper/work.go

Test Coverage:

  1. pkg/util/helper/work.go : 27.78% to 92.2%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.49%. Comparing base (e204459) to head (da62660).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5742      +/-   ##
==========================================
+ Coverage   40.85%   41.49%   +0.64%     
==========================================
  Files         651      651              
  Lines       55259    55259              
==========================================
+ Hits        22577    22932     +355     
+ Misses      31240    30846     -394     
- Partials     1442     1481      +39
Flag Coverage Δ
unittests 41.49% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anujagrawal699 anujagrawal699 mentioned this pull request Oct 24, 2024
Open
@zhzhuang-zju
Copy link
Contributor

/assign

zhzhuang-zju
zhzhuang-zju reviewed Oct 25, 2024
View reviewed changes
pkg/util/helper/work_test.go Show resolved Hide resolved
pkg/util/helper/work_test.go Outdated Show resolved Hide resolved
pkg/util/helper/work_test.go Show resolved Hide resolved
@anujagrawal699
Added tests for pkg/util/helper/work.go
da62660 
Signed-off-by: Anuj Agrawal <[email protected]>

Added tests for pkg/util/helper/work.go

Signed-off-by: Anuj Agrawal <[email protected]>
@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/util/helper/work.go branch from 5140eb1 to da62660 Compare October 25, 2024 07:54
@karmada-bot karmada-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
@XiShanYongYe-Chang
Copy link
Member

/assign

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/approve
/cc @zhzhuang-zju

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 31, 2024
@karmada-bot karmada-bot merged commit 492e24d into karmada-io:master Dec 31, 2024
15 checks passed
@RainbowMango
Copy link
Member

Hi @XiShanYongYe-Chang @anujagrawal699
This is just a reminder that the tests are failing on the master, probably due to the change of #5779.

In addition, this failing test might be a blocker for all the other PRs, please please help to investigate it.

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@whitewindmills whitewindmills Awaiting requested review from whitewindmills

@zhzhuang-zju zhzhuang-zju Awaiting requested review from zhzhuang-zju

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anujagrawal699 @codecov-commenter @zhzhuang-zju @XiShanYongYe-Chang @karmada-bot @RainbowMango