Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/karmadactl/cmdinit/bootstraptoken: unit test clusterinfo #5760

Merged
merged 1 commit into from
Dec 5, 2024
Merged

pkg/karmadactl/cmdinit/bootstraptoken: unit test clusterinfo #5760

merged 1 commit into from
Dec 5, 2024

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test clusterinfo on creating bootstrap configmap and creating cluster info RBAC rules.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (9cf4646) to head (fc28676).

Files with missing lines Patch % Lines
pkg/karmadactl/util/idempotency.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5760      +/-   ##
==========================================
+ Coverage   47.61%   47.72%   +0.11%     
==========================================
  Files         663      663              
  Lines       54761    54761              
==========================================
+ Hits        26073    26134      +61     
+ Misses      26980    26917      -63     
- Partials     1708     1710       +2
Flag Coverage Δ
unittests 47.72% <66.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mohamedawnallah mohamedawnallah mentioned this pull request Oct 31, 2024
Open
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/approve
Ask again review from @zhzhuang-zju
/cc @zhzhuang-zju

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@zhzhuang-zju
Copy link
Contributor

/assign

zhzhuang-zju
zhzhuang-zju reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@zhzhuang-zju zhzhuang-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks~ just some nits

pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo/clusterinfo_test.go Outdated Show resolved Hide resolved
pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo/clusterinfo_test.go Outdated Show resolved Hide resolved
pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo/clusterinfo_test.go Outdated Show resolved Hide resolved
pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo/clusterinfo_test.go Outdated Show resolved Hide resolved
pkg/karmadactl/cmdinit/bootstraptoken/clusterinfo/clusterinfo_test.go Show resolved Hide resolved
@mohamedawnallah mohamedawnallah force-pushed the unitTestClusterInfoBootstrapToken branch from 87316b8 to 0933c08 Compare December 5, 2024 04:43
@mohamedawnallah
pkg/karmadactl/cmdinit: unit test clusterinfo
fc28676 
In this commit, we unit test clusterinfo on creating
bootstrap configmap and creating cluster info RBAC rules.

Signed-off-by: Mohamed Awnallah <[email protected]>
@mohamedawnallah mohamedawnallah force-pushed the unitTestClusterInfoBootstrapToken branch from 0933c08 to fc28676 Compare December 5, 2024 07:19
@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@karmada-bot karmada-bot merged commit 1cbfca0 into karmada-io:master Dec 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@prodanlabs prodanlabs Awaiting requested review from prodanlabs

@zhzhuang-zju zhzhuang-zju Awaiting requested review from zhzhuang-zju

Assignees

@zhzhuang-zju zhzhuang-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohamedawnallah @codecov-commenter @karmada-bot @zhzhuang-zju @XiShanYongYe-Chang