-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for status and cronfederatedhpa helper utilities #5768
Added unit tests for status and cronfederatedhpa helper utilities #5768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5768 +/- ##
==========================================
+ Coverage 42.31% 45.61% +3.30%
==========================================
Files 655 658 +3
Lines 55756 53921 -1835
==========================================
+ Hits 23591 24598 +1007
+ Misses 30651 27724 -2927
- Partials 1514 1599 +85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others LGTM
ef26be6
to
72e7400
Compare
72e7400
to
eb6a37a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, others LGTM
pkg/util/helper/status_test.go
Outdated
Namespace: testObj.GetNamespace(), | ||
} | ||
|
||
if tt.expectedError == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tt.expectedError == "" { |
Lines L322-L327
have already handled the case where expectedError
is not empty, so there is no need to add a condition check for tt.expectedError == ""
.
Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for status and cronfederatedhpa helper utilities Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for status and cronfederatedhpa helper utilities Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for status and cronfederatedhpa helper utilities Signed-off-by: Anuj Agrawal <[email protected]>
eb6a37a
to
310e4f9
Compare
/lgtm |
expected: 3, | ||
}, | ||
{ | ||
name: "successful history limit is set to 5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a code bad taste involved here. The number 3 is a devil's number in the test case, and if we can describe it in one word, we'll be more comfortable naming the test case. For example, we can change the name of the test case to successful history limit is set to bigger than xxx
.
If you wish, you can resubmit a pr to modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense, 3 could be defined as a constant at the package level, which would make it easier to change the default value in the future if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR introduces comprehensive unit tests for status and cronfederatedhpa helper utility functions in the pkg/util/helper. These additions aim to increase code reliability, maintainability, and test coverage of the helper utility package.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: