Added unit tests for pkg/util/helper/workstatus.go #5798
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XL
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5798 +/- ##
==========================================
+ Coverage 42.84% 43.18% +0.33%
==========================================
Files 656 656
Lines 55884 55921 +37
==========================================
+ Hits 23944 24148 +204
+ Misses 30391 30215 -176
- Partials 1549 1558 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @anujagrawal699, there are some lint errors in the CI, can you help fix it? /assign |
Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for pkg/util/helper/workstatus.go Signed-off-by: Anuj Agrawal <[email protected]>
anujagrawal699
force-pushed
the
addedTests-pkg/util/helper/workstatus.go
branch
from
09e401d to
ed50e02
Compare
Hi @XiShanYongYe-Chang , yes i'll fix it. |
|
|
||
| recorder := record.NewFakeRecorder(10) | ||
|
|
||
| err := AggregateResourceBindingWorkStatus(context.TODO(), c, tt.binding, recorder) |
There was a problem hiding this comment.
This test case maybe conflict with #5779
There was a problem hiding this comment.
We'll update it once #5779 gets approved.
There was a problem hiding this comment.
I have updated #5779 , thanks for the reminder @XiShanYongYe-Chang
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Description:
This PR adds comprehensive unit tests for untested functions of the workstatus helper from the helper utility package. It introduces new tests for previously uncovered functions and refactors existing tests to use the
assertpackage fromtestify. These additions aim to increase code reliability, maintainability, and test coverage for the workstatus helper.Modifications:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: