Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for reflect status interpreter #5828

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR standardizes and enhances tests for pkg/resourceinterpreter/default/native/reflectstatus.go, focusing on consistent test patterns and better coverage. It add tests for untested functions, refactors all status reflection tests to use a unified structure, adds missing edge cases and improves assertion handling with the assert package. These changes improve test maintainability, readability, and overall coverage while ensuring consistent validation across different resource types.

Modifications:

  1. addedTests-pkg/resourceinterpreter/default/native/reflectstatus_test.go

Test Coverage:

  1. addedTests-pkg/resourceinterpreter/default/native/reflectstatus.go : 22.66 to 90.60%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 17, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.85%. Comparing base (3acc14c) to head (59f266c).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5828      +/-   ##
==========================================
+ Coverage   45.56%   45.85%   +0.29%     
==========================================
  Files         658      658              
  Lines       53921    53926       +5     
==========================================
+ Hits        24567    24730     +163     
+ Misses      27750    27583     -167     
- Partials     1604     1613       +9     
Flag Coverage Δ
unittests 45.85% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@karmada-bot karmada-bot merged commit 993fa26 into karmada-io:master Nov 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants