Added unit tests for resourceinterpreter webhook configmanager #5832
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5832 +/- ##
==========================================
+ Coverage 46.04% 48.08% +2.03%
==========================================
Files 659 663 +4
Lines 53957 54761 +804
==========================================
+ Hits 24847 26330 +1483
+ Misses 27494 26718 -776
- Partials 1616 1713 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anujagrawal699
force-pushed
the
addedTests-pkg/resourceinterpreter/customized/webhook/configmanager
branch
from
448e41d to
352446e
Compare
|
/retest |
|
@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @XiShanYongYe-Chang , can u trigger a retest? |
|
Yes~ |
|
/assign |
| configv1alpha1 "github.com/karmada-io/karmada/pkg/apis/config/v1alpha1" | ||
| ) | ||
|
|
||
| func TestNewResourceExploringAccessor(t *testing.T) { |
There was a problem hiding this comment.
This test case has been overwritten by the next test case and can be deleted.
There was a problem hiding this comment.
Hi @XiShanYongYe-Chang , Should i add these two test cases to the getters test or remove it completely?
There was a problem hiding this comment.
Should i add these two test cases to the getters test
It would be great to do this.
anujagrawal699
force-pushed
the
addedTests-pkg/resourceinterpreter/customized/webhook/configmanager
branch
from
352446e to
13dbb09
Compare
Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for resourceinterpreter webhook configmanager Signed-off-by: Anuj Agrawal <[email protected]> Added unit tests for resourceinterpreter webhook configmanager Signed-off-by: Anuj Agrawal <[email protected]>
anujagrawal699
force-pushed
the
addedTests-pkg/resourceinterpreter/customized/webhook/configmanager
branch
from
13dbb09 to
ccea4d2
Compare
|
@XiShanYongYe-Chang Please take a look! |
|
Thanks a lot |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
|
/lgtm |
Description:
This PR adds comprehensive unit tests for the resourceinterpreter webhook configmanager. These tests verify the core functionality of webhook configuration handling and access, including configuration syncing, merging, and accessor behaviors.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: