Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/karmadactl: unit test join #5871

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

In this commit, we unit test the process of joining a cluster to the Karmada control plane. The tests validate the arguments passed to the join cluster operation and ensure the creation of the new cluster runtime object. Additionally, we verify that the necessary access secrets for the new cluster in push mode are correctly generated in the Karmada control plane.

What type of PR is this?

Which issue(s) this PR fixes:
Part of #5491.

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.43%. Comparing base (6f4d69c) to head (5618eb1).

Files with missing lines Patch % Lines
pkg/karmadactl/join/join.go 66.66% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5871      +/-   ##
==========================================
+ Coverage   46.32%   46.43%   +0.11%     
==========================================
  Files         663      663              
  Lines       54756    54762       +6     
==========================================
+ Hits        25367    25431      +64     
+ Misses      27761    27692      -69     
- Partials     1628     1639      +11     
Flag Coverage Δ
unittests 46.43% <66.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

pkg/karmadactl/join/join_test.go Show resolved Hide resolved
pkg/karmadactl/join/join_test.go Show resolved Hide resolved
In this commit, we unit test the process of joining a cluster
to the Karmada control plane. The tests validate the arguments
passed to the join cluster operation and ensure the creation of
the new cluster runtime object. Additionally, we verify that the
necessary access secrets for the new cluster in push mode are correctly
generated in the Karmada control plane.

Signed-off-by: Mohamed Awnallah <[email protected]>
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@karmada-bot karmada-bot merged commit 189acaf into karmada-io:master Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants