-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/karmadactl: unit test join #5871
pkg/karmadactl: unit test join #5871
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5871 +/- ##
==========================================
+ Coverage 46.32% 46.43% +0.11%
==========================================
Files 663 663
Lines 54756 54762 +6
==========================================
+ Hits 25367 25431 +64
+ Misses 27761 27692 -69
- Partials 1628 1639 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
517dec3
to
1601652
Compare
In this commit, we unit test the process of joining a cluster to the Karmada control plane. The tests validate the arguments passed to the join cluster operation and ensure the creation of the new cluster runtime object. Additionally, we verify that the necessary access secrets for the new cluster in push mode are correctly generated in the Karmada control plane. Signed-off-by: Mohamed Awnallah <[email protected]>
1601652
to
5618eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
In this commit, we unit test the process of joining a cluster to the Karmada control plane. The tests validate the arguments passed to the join cluster operation and ensure the creation of the new cluster runtime object. Additionally, we verify that the necessary access secrets for the new cluster in push mode are correctly generated in the Karmada control plane.
What type of PR is this?
Which issue(s) this PR fixes:
Part of #5491.
Does this PR introduce a user-facing change?: