Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for the mock EstimatorClient #5894

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR adds unit tests for the mock EstimatorClient, which is used for testing the scheduler estimator service functionality in Karmada. The tests ensure proper behavior of both success and error scenarios for unschedulable replicas calculation and maximum available replicas estimation.

Additions:

  1. pkg/estimator/service/mock_EstimatorClient_test.go

Test Coverage:

  1. pkg/estimator/service/mock_EstimatorClient.go : 0% to 82.40%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (6f4d69c) to head (2532dfe).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5894      +/-   ##
==========================================
+ Coverage   46.32%   46.35%   +0.02%     
==========================================
  Files         663      663              
  Lines       54756    54756              
==========================================
+ Hits        25367    25383      +16     
+ Misses      27761    27739      -22     
- Partials     1628     1634       +6     
Flag Coverage Δ
unittests 46.35% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XiShanYongYe-Chang
Copy link
Member

/retest
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, the MockEstimatorClient itself is already prepared for testing, do we still need to test the tests?

@anujagrawal699
Copy link
Contributor Author

I have a question, the MockEstimatorClient itself is already prepared for testing, do we still need to test the tests?

Yeah you're right, i was following the path of increasing test coverage. But it is not good to write tests just for coverage numbers.
I think we should move ahead without this PR.

@XiShanYongYe-Chang
Copy link
Member

i was following the path of increasing test coverage.

We should have code maintainability as the first element. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants