-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for the mock EstimatorClient #5894
Added unit tests for the mock EstimatorClient #5894
Conversation
Signed-off-by: Anuj Agrawal <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5894 +/- ##
==========================================
+ Coverage 46.32% 46.35% +0.02%
==========================================
Files 663 663
Lines 54756 54756
==========================================
+ Hits 25367 25383 +16
+ Misses 27761 27739 -22
- Partials 1628 1634 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, the MockEstimatorClient itself is already prepared for testing, do we still need to test the tests?
Yeah you're right, i was following the path of increasing test coverage. But it is not good to write tests just for coverage numbers. |
We should have code maintainability as the first element. :) |
Description:
This PR adds unit tests for the mock EstimatorClient, which is used for testing the scheduler estimator service functionality in Karmada. The tests ensure proper behavior of both success and error scenarios for unschedulable replicas calculation and maximum available replicas estimation.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: