-
Notifications
You must be signed in to change notification settings - Fork 1k
Add custom interpreter for Raycluster #6766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add custom interpreter for Raycluster #6766
Conversation
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @owenowenisme! It looks like this is your first PR to karmada-io/karmada 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6766 +/- ##
==========================================
+ Coverage 45.73% 45.86% +0.13%
==========================================
Files 689 690 +1
Lines 57152 57392 +240
==========================================
+ Hits 26136 26322 +186
- Misses 29384 29432 +48
- Partials 1632 1638 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good so far. Thank Owne, please cc me once this ready for review.
Just a reminder, you might need it when implementing the GetComponents
interface, we have the util accuratePodRequirements
, it helps to parse the requirements from a pod template. For example:
Line 23 in 13c28a0
requirement = kube.accuratePodRequirements(podTemplateSpec) |
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
@RainbowMango Would you mind reviewing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a custom resource interpreter for RayCluster resources from the ray.io/v1 API. It provides comprehensive interpretation capabilities for handling Ray distributed computing clusters within Karmada.
Key changes:
- Implements five core operations: health interpretation, replica calculation, status aggregation, status reflection, and component resource analysis
- Provides proper handling of Ray's head and worker group architecture with resource requirements calculation
- Includes comprehensive test data and test configurations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
customizations.yaml | Main interpreter configuration with Lua scripts for all RayCluster operations |
customizations_tests.yaml | Test configuration defining test cases for each operation |
desired-raycluster.yaml | Test data representing desired RayCluster state |
observed-raycluster.yaml | Test data representing observed RayCluster state with full status |
status-file.yaml | Test data containing status information for aggregation testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Outdated
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Outdated
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Show resolved
Hide resolved
...terpreter/default/thirdparty/resourcecustomizations/ray.io/v1/RayCluster/customizations.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Sure, will do by this week. (Not sure if I have enough time before Wednesday, as I'm on a business trip.) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #6588
Special notes for your reviewer:
Does this PR introduce a user-facing change?: