-
Notifications
You must be signed in to change notification settings - Fork 1k
api(failover): Add EvictionQueueOptions to configure dynamic rate limit #6777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @whosefriendA, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the failover mechanism within the controller manager by introducing dynamic rate limiting for resource eviction. It provides new configuration parameters that allow administrators to define primary and secondary eviction rates, as well as thresholds for cluster health and scale. These parameters enable the system to intelligently adjust eviction speeds based on the current state of the Karmada instance, aiming to prevent aggressive evictions during periods of instability or in large-scale deployments, thereby improving overall system resilience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new configuration options to FailoverOptions
for dynamic rate limiting of evictions. Note that the PR title mentions EvictionQueueOptions
, but the changes are made to FailoverOptions
. The changes add new fields to the struct and corresponding command-line flags. My review focuses on the correctness and clarity of these new API additions.
I've identified a high-severity issue regarding the lack of validation for the new options, which could lead to unexpected behavior if invalid values are provided. I've also suggested a medium-severity improvement to the help text of one of the new flags for better user clarity. Overall, the changes are a good step towards implementing dynamic eviction rate limiting, but the validation aspect needs to be addressed before this can be considered complete.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6777 +/- ##
==========================================
- Coverage 45.84% 45.82% -0.03%
==========================================
Files 690 690
Lines 57300 57330 +30
==========================================
+ Hits 26271 26273 +2
- Misses 29399 29423 +24
- Partials 1630 1634 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Other PRs can also be adjusted in this way. |
53e3de4
to
ed099d1
Compare
Hi @whosefriendA, can you help fix it and squash the commit into one? |
…iting Signed-off-by: whosefriendA <[email protected]>
f47a192
to
88023ac
Compare
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
part of #6746
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: