-
Notifications
You must be signed in to change notification settings - Fork 1k
add an E2E test for dependency aggregation #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Kexin2000: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6809 +/- ##
==========================================
+ Coverage 45.75% 45.83% +0.08%
==========================================
Files 689 690 +1
Lines 57176 57300 +124
==========================================
+ Hits 26159 26266 +107
- Misses 29390 29403 +13
- Partials 1627 1631 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind feature
/kind testing
What this PR does / why we need it:
It introduces a new E2E test to ensure that shared dependencies produce a single attached
ResourceBinding
with accurateRequiredBy
tracking.Which issue(s) this PR fixes:
Fixes # 6000
Special notes for your reviewer:
test/e2e/suites/base/dependency_aggregation_test.go
to verify multi dependency tracking behavior.ResourceBinding
.RequiredBy
field in the attachedResourceBinding
includes both parents.RequiredBy
occur when one parent stops referencing the shared dependency.Does this PR introduce a user-facing change?:
None