Skip to content

Conversation

Kexin2000
Copy link

What type of PR is this?

/kind feature
/kind testing

What this PR does / why we need it:
It introduces a new E2E test to ensure that shared dependencies produce a single attached ResourceBinding with accurate RequiredBy tracking.

Which issue(s) this PR fixes:
Fixes # 6000

Special notes for your reviewer:

  • Added a new E2E test in test/e2e/suites/base/dependency_aggregation_test.go to verify multi dependency tracking behavior.
  • The test ensures:
    • Two deployments referencing the same ConfigMap produce a single attached ResourceBinding.
    • The RequiredBy field in the attached ResourceBinding includes both parents.
    • Updates to RequiredBy occur when one parent stops referencing the shared dependency.

Does this PR introduce a user-facing change?:
None

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 30, 2025
@karmada-bot
Copy link
Collaborator

@Kexin2000: The label(s) kind/testing cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/kind testing

What this PR does / why we need it:
It introduces a new E2E test to ensure that shared dependencies produce a single attached ResourceBinding with accurate RequiredBy tracking.

Which issue(s) this PR fixes:
Fixes # 6000

Special notes for your reviewer:

  • Added a new E2E test in test/e2e/suites/base/dependency_aggregation_test.go to verify multi dependency tracking behavior.
  • The test ensures:
  • Two deployments referencing the same ConfigMap produce a single attached ResourceBinding.
  • The RequiredBy field in the attached ResourceBinding includes both parents.
  • Updates to RequiredBy occur when one parent stops referencing the shared dependency.

Does this PR introduce a user-facing change?:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.83%. Comparing base (768f929) to head (e99c7d4).
⚠️ Report is 10 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6809      +/-   ##
==========================================
+ Coverage   45.75%   45.83%   +0.08%     
==========================================
  Files         689      690       +1     
  Lines       57176    57300     +124     
==========================================
+ Hits        26159    26266     +107     
- Misses      29390    29403      +13     
- Partials     1627     1631       +4     
Flag Coverage Δ
unittests 45.83% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants