Add Admission Control for Karmada Operator #6820
Conversation
Signed-off-by: Joe Nathan Abellard <[email protected]>
Signed-off-by: Joe Nathan Abellard <[email protected]>
Signed-off-by: Joe Nathan Abellard <[email protected]>
Signed-off-by: Joe Nathan Abellard <[email protected]>
Signed-off-by: Joe Nathan Abellard <[email protected]>
karmada-bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @jabellard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates admission control into the Karmada Operator, enhancing the management of Karmada resources by introducing API-level validation and defaulting. This change improves the reliability and consistency of resource configurations by enforcing rules closer to the source of truth, and provides a configurable option for operators to enable or disable this new functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
karmada-bot
added
the
size/L
karmada-bot
added
the
do-not-merge/work-in-progress
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable admission webhook for the Karmada operator, which is a best practice for handling validation and defaulting of custom resources. The implementation is clean, leveraging controller-runtime's webhook framework and cert-manager for certificate management. The feature is thoughtfully gated behind a Helm value, ensuring it's disabled by default. The refactoring to conditionally skip in-controller validation when the webhook is active is correct and avoids redundant processing. I've identified a few minor issues, mainly concerning a futuristic copyright year and missing newlines in YAML files.
| apiVersions: ["v1alpha1"] | ||
| operations: ["CREATE","UPDATE"] | ||
| resources: ["karmadas"] | ||
| {{- end }} No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. This ensures file integrity and prevents issues with some Unix tools and concatenation.
{{- end }}
| protocol: TCP | ||
| selector: | ||
| app: {{ include "karmada.operator.fullname" . }} | ||
| {{- end }} No newline at end of file |
There was a problem hiding this comment.
It's a good practice to end files with a newline character. This ensures file integrity and prevents issues with some Unix tools and concatenation.
{{- end }}
| @@ -0,0 +1,136 @@ | |||
| /* | |||
| Copyright 2025 The Karmada Authors. | |||
There was a problem hiding this comment.
The copyright year is set to 2025, which is in the future. Please update it to the current year to reflect the correct copyright information.
| Copyright 2025 The Karmada Authors. | |
| Copyright 2024 The Karmada Authors. |
There was a problem hiding this comment.
@RainbowMango, This is so funny.
There was a problem hiding this comment.
LOL ;) Maybe the model was trained last year.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6820 +/- ##
==========================================
- Coverage 45.87% 45.81% -0.07%
==========================================
Files 690 691 +1
Lines 57392 57478 +86
==========================================
Hits 26331 26331
- Misses 29425 29510 +85
- Partials 1636 1637 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
Please see #6819
Which issue(s) this PR fixes:
Fixes #6819
Special notes for your reviewer:
Does this PR introduce a user-facing change?: