Fix plugin behavior to show default placeholder when allowEmpty is …

…`true` fixes #20 fixes #21
kartik-v · May 23, 2017 · e783ca6 · e783ca6
1 parent ed962db
commit e783ca6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/CHANGE.md b/CHANGE.md
@@ -10,6 +10,7 @@ Change Log: `yii2-money`
     - fixes masking when precision is set but the decimal part length is less than precision length (for example 1400.50 with precision 2 was wrongly displayed as 140.05 - this change fixes this bug where the leading zeros after decimals were omitted)
 - (enh #25, #11, #10): Update to release v3.1.1 of source plugin.
 - (bug #24, #17, #12, #4): Enhance to calculate changed money mask when enter key is pressed.
+- (enh #21, #20): Fix plugin behavior to show default placeholder when `allowEmpty` is `true`.
 - (enh #15): New `displayInputName` property to control display input name attribute.
 - Add composer alias for latest dev master release.
 - Add github contribution and issue/PR logging templates.

diff --git a/assets/js/jquery.maskMoney.js b/assets/js/jquery.maskMoney.js
@@ -219,7 +219,9 @@
 
                 function mask() {
                     var value = $input.val();
-                    if (settings.allowEmpty && value === "") {
+                    // corrected by Kartik for initial empty value being treated as NaN
+                    if (settings.allowEmpty && (value === "" || isNaN(parseFloat(value)))) {
+                        $input.val("");
                         return;
                     }
                     if (settings.precision > 0 && value.indexOf(settings.decimal) < 0) {

diff --git a/assets/js/jquery.maskMoney.min.js b/assets/js/jquery.maskMoney.min.js