Ticket 342 #347
Merged
Ticket 342 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimasciput
requested changes
Feb 10, 2025
| @@ -143,6 +143,30 @@ ckan.module("spatial_search", function($){ | |||
| $(this).css({"cursor":"pointer"}) | |||
| }) | |||
|
|
|||
| $('i.fa-pencil').on('click', function(e){ | |||
There was a problem hiding this comment.
@voogt I couldn't find this icon, is this on the leaflet map? Could you share a screen recording for this PR please?
There was a problem hiding this comment.
Hi @dimasciput its this button in the screenshot below. Its part of ckan-spatial plugin
That part of the code is to address a bug in the plugin for the base map not loading. If I remove the click listener, below image is the result
dimasciput
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address ticket #342
Screencast from 2025-02-11 08-07-54.webm