-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(emscripten): ensure EMSDK setup completes before WASM compilation #54
Conversation
IIRC the way it is supposed to work in the sokol-zig build.zig is that the sokol C library depends on the Emscripten setup step, and then all other C libraries depend on the sokol library. E.g. the ...and the in the sokol-zig-imgui-sample project, the cimgui lib depends on sokol: ...so basically, Emscripten setup finishes first, then the sokol C library is compiled, and then all other C libraries. |
Oh... the errors here (assert.h not found): https://github.com/kassane/sokol-d/actions/runs/13225929376/job/36916768510 ...look entirely different then the CI error in this PR (those are all linker errors): https://github.com/kassane/sokol-d/actions/runs/13265008351/job/37030179876 |
Exactly! ldc2 replace libsokol to libimgui config. 🤦♂️ (I'll fix) ---edit Why windows works? |
Evaluating the current build process involving imgui:
*ldc2/ldmd2 requires reading the header to autogenerate imgui-bindings. Unlike libsokol which has bindings generated in the sokol-upstream. Also ldc2/ldmd2 get all includes + flags/defines from libsokol! |
for wasm32 - ldc2 step force libsokol-step dependOn
Ok. I need help (MacOS user)!! |
Finally 96a06db ✔️ (need review) |
Why dub in windows tried linking sokol_imgui on non-imgui samples? |
This reverts commit 379a543.
closes #53
based on: https://github.com/floooh/sokol-zig-imgui-sample/blob/main/build.zig