Skip to content

Comments

deps: update nix to 0.20.2#59

Merged
Tim-Zhang merged 2 commits intokata-containers:mainfrom
jmagnuson:update-nix-0.20.2
Nov 11, 2021
Merged

deps: update nix to 0.20.2#59
Tim-Zhang merged 2 commits intokata-containers:mainfrom
jmagnuson:update-nix-0.20.2

Conversation

@jmagnuson
Copy link

Enforces use of a version of nix which contains a patch for
RUSTSEC-2021-0119.

Fixes #58

Signed-off-by: Jon Magnuson jon.magnuson@gmail.com

Enforces use of a version of nix which contains a patch for
RUSTSEC-2021-0119.

Fixes kata-containers#58

Signed-off-by: Jon Magnuson <jon.magnuson@gmail.com>
Copy link

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmagnuson.

lgtm

@jmagnuson
Copy link
Author

I believe rust-lang/rust-clippy#7254 included in clippy 1.54 triggered the lint failure. Went ahead and fixed in 41ed4a9.

@Tim-Zhang
Copy link
Member

@jmagnuson the ci failed caused by 41ed4a9 has no commit body

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jmagnuson

Fix needless-borrow in test.

Signed-off-by: Jon Magnuson <jon.magnuson@gmail.com>
@Tim-Zhang
Copy link
Member

@jmagnuson I have fixed the missing of commit-body already.

@Tim-Zhang Tim-Zhang merged commit da75ba2 into kata-containers:main Nov 11, 2021
@jmagnuson jmagnuson deleted the update-nix-0.20.2 branch November 12, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to nix 0.20.2

3 participants