Skip to content

Auto-create directories for custom TEXTINCLUDE 1 header paths #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katahiromz merged 6 commits into from
Nov 28, 2025
Merged

Auto-create directories for custom TEXTINCLUDE 1 header paths #339

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
337fd65
Initial plan
Copilot Nov 28, 2025
a3df670
Add automatic directory creation for TEXTINCLUDE 1 paths like include…
Copilot Nov 28, 2025
b0b81ec
Add automatic directory creation when copying custom header file from…
Copilot Nov 28, 2025
33f342e
Add error handling for directory creation in TEXTINCLUDE 1 custom pat…
Copilot Nov 28, 2025
57c19f1
Simplify error handling comment for directory creation
Copilot Nov 28, 2025
d23af31
Fix duplicate error message when directory creation fails
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/RisohEditor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8906,6 +8906,22 @@ BOOL MMainWnd::DoWriteRC(LPCWSTR pszFileName, LPCWSTR pszResH, const EntrySet& f
StringCchPrintfW(szMsg, _countof(szMsg), LoadStringDx(IDS_COPYHEADERFILE), textinclude1_w.c_str());
if (MsgBoxDx(szMsg, MB_ICONQUESTION | MB_YESNO) == IDYES)
{
// Create parent directory if it doesn't exist
// This handles paths like "include\resource.h" or "include/resource.h"
WCHAR szDestHeaderDir[MAX_PATH];
StringCchCopyW(szDestHeaderDir, _countof(szDestHeaderDir), szDestHeaderPath);
PathRemoveFileSpecW(szDestHeaderDir);
if (szDestHeaderDir[0] && !PathIsDirectoryW(szDestHeaderDir))
{
INT nResult = SHCreateDirectoryExW(NULL, szDestHeaderDir, NULL);
if (nResult != ERROR_SUCCESS && nResult != ERROR_ALREADY_EXISTS)
{
// Directory creation failed, show error to user
ErrorBoxDx(IDS_CANNOTSAVE);
// Continue to try CopyFileW anyway, which will also fail
}
}

if (!CopyFileW(szSrcHeaderPath, szDestHeaderPath, FALSE))
{
// Copy failed, show error to user
Expand Down