Skip to content

fix(pre-commit): remove unnecessary noqa comment and dev dependencies#102

Closed
Copilot wants to merge 3 commits intolm/sirfrom
copilot/sub-pr-101
Closed

fix(pre-commit): remove unnecessary noqa comment and dev dependencies#102
Copilot wants to merge 3 commits intolm/sirfrom
copilot/sub-pr-101

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 20, 2025

Pre-commit ruff check failed due to an obsolete noqa: PLR2004 comment in test file that no longer required suppression.

Changes

  • Removed auto-fixed noqa comment from tests/test_models/test_pendulum.py
  • Reverted unnecessary mypy/pandas-stubs additions to pyproject.toml (already configured in .pre-commit-config.yaml additional_dependencies)

All SIR model files pass pre-commit checks. Pre-existing mypy errors in kepler_problem, free_particle, harmonic_oscillator_chain, and brownian_motion modules remain unchanged as they're unrelated to this PR.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 20, 2025 12:51
Co-authored-by: emptymalei <663798+emptymalei@users.noreply.github.com>
Co-authored-by: emptymalei <663798+emptymalei@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Dec 20, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/kausalflow/hamilflow/actions/jobs/35145312818/logs
    • Triggering command: /usr/bin/curl curl -s -H Accept: application/vnd.github&#43;json REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix pre-commit issue in SIR model fix(pre-commit): remove unnecessary noqa comment and dev dependencies Dec 20, 2025
Copilot AI requested a review from emptymalei December 20, 2025 12:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2026

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2026-03-27 18:54 UTC

@emptymalei emptymalei closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants