switch listener to tcp4 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! 🚢 |
ashoksahoo
approved these changes
Nov 9, 2017
JensRantil
requested changes
Nov 14, 2017
|
It doesn't, tried both locally and in mesos.
…On Nov 14, 2017 6:15 AM, "Jens Rantil" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hm, but doesn't this remove support for TCP6? Have you tried doing -listen
1.2.3.6:7979 instead? That should make it listen to TCP4, no?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWcT8Pe-SoEFy4roaDZeFBSgGnvnvoJZks5s2YRLgaJpZM4QNMmE>
.
|
JensRantil
requested changes
Nov 14, 2017
| @@ -81,7 +82,11 @@ func main() { | |||
| ) | |||
| prometheus.DefaultRegisterer.MustRegister(collector) | |||
|
|
|||
| log.Fatal(http.ListenAndServe(c.String("listen"), promhttp.Handler())) | |||
| l, err := net.Listen("tcp4", c.String("listen")) | |||
There was a problem hiding this comment.
How about making the first parameter to net.Listen(...) a flag, too? That would allow someone to use this application with IPv6 if they'd like to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as built the listener only listened on ipv6. I am running this as a mesos job and needed to have it listen on a ipv4 interface.