-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build shared library for Apple Silicon #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left some comments.
Apple sillicon support has been strongly demanded so this would be appreciated by many :) #36
Btw I'm wondering if this issue has been fixed: #36 (comment)
Apparently it did? as in this PR already passing CI.
src/main/java/io/github/kawamuray/wasmtime/NativeLibraryLoader.java
Outdated
Show resolved
Hide resolved
Updated the build.gradle and the loading logic to use the following paths (grabbed these from a tagged build on the fork to confirm):
On #36 - I think my timing was just lucky! I didn't run into any cross-compilation issues, so it must have been fixed upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This adds support for an
aarch64
build of the shared library, and updates the NativeLibraryLoader to load it on macOS when theos.arch
system property isaarch64
.Although it's pretty straightforward to build for this architecture, running the tests is a lot more complex so I've disabled them when cross-compiling for now. It looks like bytecodealliance/wasmtime uses qemu to solve this problem for some architectures, but it's not as simple as just setting a target.