Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add end-to-end testing #22

Merged
merged 8 commits into from
Feb 14, 2025
Merged

✨ Add end-to-end testing #22

merged 8 commits into from
Feb 14, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 11, 2025 •
edited
Loading

Summary

This introduces a new ProwJob to run end-to-end tests. I tried to keep it lean and easy to grasp:

  • I chose not to run everything in a kind cluster as that doesn't really offer any benefit over just running the 2 binaries manually. Quite the opposite, with kind we'd also need Helm and cert-manager and things would take considerably longer.
  • Instead, kcp is simply downloaded from GitHub and started as a background process. Likewise, the agent binary is built and started as needed for each testcase.
  • The kcp process is shared between all tests, but each test creates its own "root" workspace (called "organization"), so the tests should not affect each other.
  • Each org workspace automatically gets an APIExport and 2 team workspaces beneath it. The APIExport is also automatically bound in those team workspaces so that the virtual workspace is up and running when the agent tries to use it.

Related issue(s)

basis for #16

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 11, 2025
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 11, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Feb 11, 2025

/test pull-api-syncagent-test-e2e

@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Feb 12, 2025

/test pull-api-syncagent-test-e2e

@xrstf
Copy link
Contributor Author

xrstf commented Feb 12, 2025

/test pull-api-syncagent-test-e2e

@xrstf xrstf marked this pull request as ready for review February 12, 2025 10:21
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@xrstf xrstf requested a review from embik February 12, 2025 11:39
@embik embik self-assigned this Feb 12, 2025
xrstf added 8 commits February 12, 2025 14:06
@xrstf
WIP
1c3496e 
On-behalf-of: @SAP [email protected]
@xrstf
download kcp via Makefile, do not mark tools as PHONY
5d3b31f 
On-behalf-of: @SAP [email protected]
@xrstf
start kcp natively without kind, use envtest
0e24491 
On-behalf-of: @SAP [email protected]
@xrstf
add basic tester utils
ffa9c0d 
On-behalf-of: @SAP [email protected]
@xrstf
loads of improvements, can now actually start the agent without it cr…
59b4fa2 
…ashing immediately

On-behalf-of: @SAP [email protected]
@xrstf
actually test something useful
a987006 
On-behalf-of: @SAP [email protected]
@xrstf
Go 1.24 compat, fix boilerplate checking
eb01108 
On-behalf-of: @SAP [email protected]
@xrstf
The linter 'tenv' is deprecated (since v1.64.0) due to: Duplicate fea…
a1924a1 
…ture another linter. Replaced by usetesting.

On-behalf-of: @SAP [email protected]
@xrstf xrstf mentioned this pull request Feb 12, 2025
Merged
embik
embik approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e8fa542a902dbefe33236e1f6684b616ce421fa

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@kcp-ci-bot kcp-ci-bot merged commit 242e2e6 into main Feb 14, 2025
12 checks passed
@kcp-ci-bot kcp-ci-bot deleted the e2e-tests branch February 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kcp-ci-bot @embik