✨ Allow to configure an authorization webhook #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected]
… the shard reconcile which accidentally used the rootshard's etcd tls secret ref On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
release-note
|
LGTM label has been added. Git tree hash: a94aa00605fd03663c1c1462877af2d3caebd766
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a new
Authorizationfield to the CommonShardSpec, similar to the audit webhook. I then generalized applying the CommonShardSpec onto a Deployment by having aApplyCommonShardConfigurationfunction, which now also (since it's configured in it) takes care of setting up etcd and the image. That image part feels a bit weird at first, but IMHO it's at least consistent: all CommonShardSpec things are handled in a single place.Release Notes