Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 remove superflous output from make install command #3313

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Feb 26, 2025

Summary

The output from make install no longer matches the output in the docs. So we just remove that to prevent confusion as to what to execute.

Related issue(s)

Fixes #

Release Notes

remove superflous output from make install command

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @Skarlso. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 26, 2025
@Skarlso Skarlso force-pushed the doc-update-location branch from e5ca2c1 to cc7aa9d Compare February 26, 2025 08:52
@Skarlso Skarlso changed the title doc: update location of plugins for manual install 📖 update location of plugins for manual install Feb 26, 2025
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 26, 2025
@Skarlso Skarlso force-pushed the doc-update-location branch from cc7aa9d to 47a9b9b Compare February 26, 2025 08:57
@Skarlso Skarlso changed the title 📖 update location of plugins for manual install 📖 remove superflous output from make install command Feb 26, 2025
@embik
Copy link
Member

embik commented Feb 26, 2025

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f99eb251db0ac2d64e98c88b5b8c481afc539f74

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@kcp-ci-bot kcp-ci-bot merged commit 1e741bb into kcp-dev:main Feb 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants