Added support for external etcd in cache-server#3831
Merged
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom Feb 10, 2026
Merged
Added support for external etcd in cache-server#3831kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
kcp-ci-bot merged 2 commits intokcp-dev:mainfrom
Conversation
On-behalf-of: @SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
Contributor
|
LGTM label has been added. DetailsGit tree hash: 22601de6f4db01b1c615b0791f2213d83b5bbdc3 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test pull-kcp-test-e2e-sharded flake #3811 :( |
Member
|
@ntnn eh, let's give it another shot then |
neolit123
reviewed
Feb 10, 2026
| numberOfShards := flag.Int("number-of-shards", 1, "The number of shards to create. The first created is assumed root.") | ||
| cacheSyntheticDelay := flag.Duration("cache-synthetic-delay", 0, "The duration of time the cache server will inject a delay for to all inbound requests.") | ||
| quiet := flag.Bool("quiet", false, "Suppress output of the subprocesses") | ||
| cacheServerKubeconfig := flag.String("cache-kubeconfig", "", "Path to a kubeconfig of an external cache-server. If empty, a dedicated cache-server is started.") |
Contributor
There was a problem hiding this comment.
Suggested change
| cacheServerKubeconfig := flag.String("cache-kubeconfig", "", "Path to a kubeconfig of an external cache-server. If empty, a dedicated cache-server is started.") | |
| cacheServerKubeconfig := flag.String("cache-kubeconfig", "", "Path to a kubeconfig of an external cache server. If empty, a dedicated cache server is started.") |
| } | ||
|
|
||
| func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numberOfShards int, quiet bool, cacheSyntheticDelay time.Duration) error { | ||
| func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numberOfShards int, quiet bool, cacheSyntheticDelay time.Duration, cacheServerConfigPath string) error { |
Contributor
There was a problem hiding this comment.
Suggested change
| func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numberOfShards int, quiet bool, cacheSyntheticDelay time.Duration, cacheServerConfigPath string) error { | |
| func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numberOfShards int, quiet bool, cacheSyntheticDelay time.Duration, cacheServerKubeconfig string) error { |
or keep the name the flag variable the same for consistency.
Comment on lines
+117
to
118
| o.Etcd.AddFlags(fs) | ||
| o.EmbeddedEtcd.AddFlags(fs) |
Contributor
There was a problem hiding this comment.
should the external and local etcd flags be somewhat mutually exclusive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds etcd flags to cache-server command. It's now possible to point the cache-server to an external etcd cluster:
Once running, it can be then referenced from the
sharded-test-serverlike so:What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #3822
Release Notes