[WIP] Disallow --external-hostname and set based on --shard-base-url or --bind-address#3832
Open
ntnn wants to merge 1 commit intokcp-dev:mainfrom
Open
[WIP] Disallow --external-hostname and set based on --shard-base-url or --bind-address#3832ntnn wants to merge 1 commit intokcp-dev:mainfrom
ntnn wants to merge 1 commit intokcp-dev:mainfrom
Conversation
…ind-address Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
kcp-ci-bot
added
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/M
Member
Author
|
Mhm, saw this while looking through other things: https://github.com/xrstf/kcp/blob/570d782411548335dd9aa41fb98bbf1e94b4a935/pkg/server/config.go#L583-L589 So |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disallow setting
--external-hostnameand set based on--shard-base-urlor--bind-addressinstead.In kcp-operator we are already forcing
--external-hostnameto--shard-base-url: https://github.com/kcp-dev/kcp-operator/blob/850a5f963929303bc1b3c311aa7a23360ab7b871/internal/resources/shard/deployment.go#L203-L204What Type of PR Is This?
/kind cleanup
Related Issue(s)
Somewhat related to #3830, but not directly.
Release Notes