Minor design improvements

kean · Sep 11, 2024 · c4c3d56 · c4c3d56
1 parent ea09a55
commit c4c3d56
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 14 deletions.
diff --git a/Sources/PulseUI/Features/Console/List/ConsoleListContentView.swift b/Sources/PulseUI/Features/Console/List/ConsoleListContentView.swift
@@ -23,6 +23,7 @@ struct ConsoleListContentView: View {
             Text("Empty")
                 .font(.subheadline)
                 .foregroundColor(.secondary)
+                .listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
         } else {
             ForEach(viewModel.visibleEntities, id: \.objectID) { entity in
                 let objectID = entity.objectID
@@ -33,11 +34,12 @@ struct ConsoleListContentView: View {
                     .onDisappear { viewModel.onDisappearCell(with: objectID) }
 #endif
 #if os(iOS)
-                    .listRowInsets(EdgeInsets(top: 10, leading: 20, bottom: 10, trailing: 16))
+                    .listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
 #endif
             }
         }
         footerView
+            .listRowInsets(EdgeInsets(top: 12, leading: 20, bottom: 12, trailing: 16))
     }
 
     @ViewBuilder

diff --git a/Sources/PulseUI/Features/Console/List/ConsoleListView.swift b/Sources/PulseUI/Features/Console/List/ConsoleListView.swift
@@ -69,7 +69,8 @@ private struct _ConsoleListView: View {
                 ConsoleSearchListContentView()
             } else {
                 ConsoleToolbarView()
-                    .listRowSeparator(.hidden, edges: .top)
+                    .listRowSeparator(.hidden, edges: .all)
+                    .listRowInsets(EdgeInsets(top: 4, leading: 16, bottom: 8, trailing: 16))
                 ConsoleListContentView()
             }
         }

diff --git a/Sources/PulseUI/Features/Console/Views/ConsoleMessageCell.swift b/Sources/PulseUI/Features/Console/Views/ConsoleMessageCell.swift
@@ -39,14 +39,13 @@ struct ConsoleMessageCell: View {
                 .foregroundColor(titleColor)
             Spacer()
             Components.makePinView(for: message)
-            HStack(spacing: 3) {
-                ConsoleTimestampView(date: message.createdAt)
-                    .overlay(alignment: .trailing) {
-                        if isDisclosureNeeded {
-                            ListDisclosureIndicator()
-                                .offset(x: 11, y: 0)
-                        }
-                    }
+            ConsoleTimestampView(date: message.createdAt)
+                .padding(.trailing, 3)
+        }
+        .overlay(alignment: .trailing) {
+            if isDisclosureNeeded {
+                ListDisclosureIndicator()
+                    .offset(x: 8, y: 0)
             }
         }
     }

diff --git a/Sources/PulseUI/Features/Console/Views/ConsoleTaskCell.swift b/Sources/PulseUI/Features/Console/Views/ConsoleTaskCell.swift
@@ -21,8 +21,8 @@ struct ConsoleTaskCell: View {
     var body: some View {
         VStack(alignment: .leading, spacing: 3) {
             header
+            content // .padding(.top, 4)
             details
-            content.padding(.top, 3)
         }
     }
 
@@ -36,6 +36,7 @@ struct ConsoleTaskCell: View {
             info
             Spacer()
             ConsoleTimestampView(date: task.createdAt)
+                .padding(.trailing, 3)
         }
         .overlay(alignment: .leading) {
             StatusIndicatorView(state: task.state(in: store))
@@ -44,7 +45,7 @@ struct ConsoleTaskCell: View {
         .overlay(alignment: .trailing) {
             if isDisclosureNeeded {
                 ListDisclosureIndicator()
-                    .offset(x: 11)
+                    .offset(x: 8)
             }
         }
     }

diff --git a/Sources/PulseUI/Features/Console/Views/ConsoleToolbarView.swift b/Sources/PulseUI/Features/Console/Views/ConsoleToolbarView.swift
@@ -139,11 +139,13 @@ struct ConsoleListOptionsView: View {
         Button(action: { filters.options.isOnlyErrors.toggle() }) {
             Text(Image(systemName: filters.options.isOnlyErrors ? "exclamationmark.octagon.fill" : "exclamationmark.octagon"))
                 .font(.body)
-                .foregroundColor(.red)
+                .foregroundColor(filters.options.isOnlyErrors ? .white : .secondary)
         }
         .cornerRadius(4)
-        .padding(.leading, 1)
         .dynamicTypeSize(...DynamicTypeSize.accessibility1)
+        .padding(7)
+        .background(filters.options.isOnlyErrors ? .red : Color(.secondarySystemFill).opacity(0.8))
+        .clipShape(RoundedRectangle(cornerRadius: 10))
     }
 }