-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FAQs section to homepage #92
Conversation
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
✅ Deploy Preview for kedro-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I really like this, thanks for the preview. I found myself playing around with the sections to see where I could click to expand as it seemed a bit inconsistent as to where and when it opened (it doesn't work on the left hand side of the section, under the question text). I found that a bit odd -- the expand works above the text question but not below? Does that make sense? I can make a small video or show you on a screen share if it helps. But the rest is amazing and this is such a small point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! ⭐
Hy Tynan. thanks for this. Looks great. A couple of comments as flagged:
I will create mobile view today. Thanks, its looking great! |
Signed-off-by: Tynan DeBold <[email protected]>
Nice, thanks for the feedback. I've updated the accordion hit area and the background colors. Unfortunately, all the logos have a black background: Can you help with changing the background to be transparent? All the files are here. I'll also look into the transition timing. |
Good point. I could change to background colour of the logos to the dark grey. On the timing of the accordion and fade overlap (last point in previous comment), if we think timings of fade will be too tight, could each section of the accordion have a background colour that matches the section background colour (dark grey). This would help in not seeing the fade as the sections move up and down? At least I think it would help :) |
Signed-off-by: Tynan DeBold <[email protected]>
I don't think the background color will do anything. I added an For the images, yeah that would be great. Can you make the background transparent? Wouldn't want us to have to always be changing the color if we change the section background color again in the future. |
Looks great!! https://mckinsey.box.com/s/dh2waz3w6n62heoibebydk2mmlzlic8w |
/> | ||
</svg> | ||
</motion.div> | ||
<AnimatePresence initial={false}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very cool, I've never used it before. I didn't know we use this for the website 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
framer-motion you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tynandebold all working fine for me, couldn't spot any issue 😄
Signed-off-by: Tynan DeBold <[email protected]>
Great, thank you @Mackay031. And yes, same logos for desktop and mobile, so no need to do anything else. Let me know when the mobile designs are ready and I'll implement that. |
Signed-off-by: Tynan DeBold <[email protected]>
Description
Resolves #71.
Development notes
The content for this module is powered by a TypeScript file and each question/answer is an object. To edit the questions, you'll edit that file. There's a slight oddity with how we have to write the answers when we want unordered lists. It isn't that bad and it's quick to pick up that pattern.
QA notes
Take a look at the deployed URL and check it against the design.
I'm still waiting on the mobile design from @Mackay031. We'll also need to decide on a background color for this section. In the design it was black, but that's the same as the sections above and below the FAQ, which didn't look great, so I've changed it for now.
Checklist