-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update broken OmegaConfigLoader test #3696
Merged
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
cc28696
Add official support for Python 3.12
astrojuanlu 74705b8
Mark broken test as xfail
astrojuanlu 4dc83f2
Overwrite inherited get to use __getitem__
d01541f
Appease mypy
43ab544
Fix test
afa5b1b
Merge branch 'main' into feat/python-3-12
AhdraMeraliQB 62481cc
Fix test coverage
d544384
Merge branch 'feat/python-3-12' of github.com:kedro-org/kedro into fe…
f459d2f
Use spy instead of patch
9afc366
Make comment more clear
642822f
Remove redundant test assert
bdadc8d
Remove redundant variable
6e6324a
Fix broken docs link
821f491
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB 2ed5ce0
Fix broken docs link
629d16f
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB ee6ed6a
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB 9a4963f
Update docstring to reflect test
02bf45e
Add test to ensure deduplication
f6b4aa3
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB 5339ce4
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB 59d3a57
Merge branch 'main' into fix/failing-overlap-logic
AhdraMeraliQB 6314091
Trim test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this removed?