-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Passkeys: Add publicKey to register response #12757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Passkeys: Add publicKey to register response #12757
Conversation
017fc17 to
fee044d
Compare
|
Need to add some exceptions for Botan 2. |
|
Can we add a test for this response? |
I'll try. We use predefined values for the keys so it should be possible. EDIT: We are not actually creating any keys in the tests so.. I'll try to modify the tests so we can create actual keys with const predefined data. |
06ecbea to
d0735de
Compare
|
Modified the And of course the private key data changes affected to some other tests too. |
Adds a DER SubjectPublicKeyInfo to the passkey registration response. We are currently not writing this, even if It is part of the specification https://w3c.github.io/webauthn/#sctn-public-key-easy:
Fixes a passkey creation on Logitech site https://id.logi.com.
Testing strategy
Manually with: keepassxreboot/keepassxc-browser#2782
Tested https://webauthn.io with all three different algorithms to verify the response has the new
publicKeyin base64 format in the browser logs.Type of change