Don't add alarm for dates without times #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natural language dates like `--due-date=today` don't have relevant time info, so we don't add the time to the reminder. In this case if we add an alarm with the date it just sets the time at midnight. In this case we can just not add a time, which roughly matches the Reminders.app UI where adding a date vs time is separate. If you pass `--due-date=9am` it still sets the alarm correctly. Fixes #79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Natural language dates like
--due-date=todaydon't have relevant timeinfo, so we don't add the time to the reminder. In this case if we add
an alarm with the date it just sets the time at midnight. In this case
we can just not add a time, which roughly matches the Reminders.app UI
where adding a date vs time is separate. If you pass
--due-date=9amitstill sets the alarm correctly.
Fixes #79