refactor: make CLI async #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
force-pushed
the
async-cli
branch
2 times, most recently
from
6d02ade to
502f6f3
Compare
# Conflicts: # cli.js
fisker
commented
Mar 4, 2025
| function sortPackageJsonFiles(patterns, { ignore, ...options }) { | ||
| const files = globSync(patterns, { ignore }) | ||
| async function sortPackageJsonFiles(patterns, { ignore, ...options }) { | ||
| const files = await glob(patterns, { ignore }) |
There was a problem hiding this comment.
In the original implmention I want to use globStream from globby, but tinyglobby doesn't support.
fisker
commented
Mar 4, 2025
| try { | ||
| sortPackageJsonFile(file, reporter, isCheck) | ||
| await sortPackageJsonFile(file, reporter, isCheck) | ||
| } catch (error) { | ||
| reporter.reportFailed(file, error) | ||
| } | ||
| } |
There was a problem hiding this comment.
Still running serially, hard to make test pass if switch to parallel, I guess we can revist later.
fisker
commented
Mar 4, 2025
| import sortPackageJson from './index.js' | ||
| import Reporter from './reporter.js' | ||
| import packageJson from './package.json' with { type: 'json' } |
There was a problem hiding this comment.
Should I move this to showVersion?
keithamus
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #278, will rebase after #278 merged.Forgot we still support Node.js v12, we'll have to wait untill we drop it.