Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: oreo remote conf #135

Open
wants to merge 12 commits into
base: f/aws-sns-sts
Choose a base branch
from
Open

WIP: oreo remote conf #135

wants to merge 12 commits into from

Conversation

vidma
Copy link
Contributor

@vidma vidma commented Jan 5, 2023

  • Circuit breakers
    • finish circuit breakers integration (track ksu.lds_names)
  • Remote conf
    • override global stats switch(es) remotely: dsl/extractors: compute_stats
    • http client + specs
    • init with global conf, so usage could be simpler ?
    • later: cache requests/responses by LDS name (if multiple PDS of same LDS) ?
    • later: finish handling the case for new/unknown metrics (unknown by backend stats or columns)
  • Fixes for API integration:
    • header: Accept
    • logicalDatasources -> logicalDataSources
    • in resp it could be both ldsName and ldsPath
  • write small integration test with all the tools above
    • check if override global stats conf remotely works: input/output stats
    • make sure to disable stats for in-memory DS
  • double-check/update PySpark integration
    • circuitbreaker python wrapper code (exists, just add to kensu-py)
    • anything else
  • numpy / ndarray - might be slow? maybe stats should be deprecated/disabled here by default (as there's no direct read)? maybe there's write?
  • bigquery
  • pandas: simple inefficient
  • later: pandas: make it faster, but more complex
  • requests: api.py: count: len(json)
  • psychopg2
    • output stats via pandas extractor (but need tweaks)
  • matplotlib
    * stats via pandas extractor, but modified afterwards. need something special here
  • aiflow
    • bigquery

unclear:

  • bigquery (part of): one unclear special case
  • boto3: custom end-user reported stats
    • not covered/known by backend as might not relate to schema nor known metric names, how should remote enable/disable work here?
    • just keep it always enabled?
    • kensu_put(): check what is put_body.metadata['stats'] ?
  • ML: glounts -not clear. seem to be via pandas/numpy (DF, Series, ndarray) or no stats
  • ML: what about sklearn ML metrics ?

these seem to have no stats:

  • ML: sklearn (no stats there, it seems?)
  • json, pickle, pysftp, pandas_gbq: no stats

@vidma vidma marked this pull request as ready for review February 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant