lineage fixes: numpy, DataFrame, specs #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f8544f1.
vidma
commented
Dec 12, 2022
Comment on lines
+49
to
+71
| def assert_msg_exists(self, msg, msg2=None): | ||
| with open(self.offline_file, "r") as f: | ||
| assert bool([True for l in f.readlines() if msg in l and (msg2 is None or msg2 in l)]) | ||
|
|
||
| def assert_ndarray(self, v): | ||
| assert str(type(v)) == "<class 'kensu.numpy.ndarray'>" | ||
|
|
||
| def test_df_indexed_value(self): | ||
| out_fname1 = 'test_df_column.indexer.values' | ||
| out_fname = 'test_df_indexed_list_of_ndarray' | ||
| dummy_ts_df = pd.read_csv('https://raw.githubusercontent.com/numenta/NAB/master/data/realTweets/Twitter_volume_AMZN.csv', index_col=0) # header=0, | ||
| # <class 'kensu.pandas.data_frame.DataFrame'> | ||
|
|
||
| l1 = [] | ||
| # here `value` is a column name! | ||
| value_series = dummy_ts_df.value[:"2015-04-05 00:00:00"] # <class 'kensu.pandas.data_frame.Series'> | ||
| # probably not supporting passing list(Series) to constructor of ndarray? | ||
| v = value_series.values # ndarray | ||
| self.assert_ndarray(v) | ||
| ndarray_to_csv(v, out_fname1) | ||
| self.assert_msg_exists('Lineage to kensu-py/test_df_column.indexer.values from realTweets/Twitter_volume_AMZN.csv', | ||
| '"columnDataDependencies": {"0": ["value"]}}') | ||
|
|
There was a problem hiding this comment.
example of integration test "pattern":
- kensu-py collector writes to
offline ingestion jsonl fileas usual withreport_to_file=True - test helper in
assert_msg_existsread offline ingestion jsonl file - we check for certain patterns in the jsonl file (here just if certain line or string exists - seems enough for now, in spark-collector it's fancier - parse and transform jsonl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array(int, int, int, int, ... <50000 times more>)add_dependenciesto use newer methods underneathlist(ndarray[ndarray[..]])